Received: by 2002:aa6:c429:0:b029:98:93ff:f56f with SMTP id g9csp4947098lkq; Thu, 10 Dec 2020 12:49:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJyMbDVtGGMtAlXXMdh2ZgFy2a6Dgr5F8FdkEEfQxY0SQWjTAZ7xeqcVVr6FIvxfQNCnDX/7 X-Received: by 2002:a50:d5c4:: with SMTP id g4mr8366393edj.334.1607633364284; Thu, 10 Dec 2020 12:49:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607633364; cv=none; d=google.com; s=arc-20160816; b=N49N7Dk9AYKqULhULu3aHcDR3keJIgquMVk/WyrLNFz3FPyt9ElV34PvArJgCy79zN o/5q/ORqFbPdfeAKCfZ6sZfqLLbLutl6dG6t73XWa9wmzX+FlVubdpoirY5ChTF4sKDi 6+MJ2ueUkdEmMtJP+43jN98GQlVDYYVKhefKWXQqCfcY8tVAXJ6CtYMXntlVcXLFgyk9 pxEPByyKqZpGdzxHrU3x6N+hJe97djmmgMqEH+DwsHvQKf8kGdgIghgNoYfdOcmyMWMa AwJUOyfpI8hbQ3tNUiyF/HdIOz6HEHvxSPkcZHYQYIuZsBvSigzd34Y9sDXYwxjiQ1KE 2s7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=1lIUjz9Y+LswtQ+/mYN89TGY+HFfqIBGnWBXGr04qoU=; b=ryFHJXRwDsB3UAgSWlDub4V2AWFl3BaPvPdsHzuWwW9G77oLQaGkgkkexxHb9vH4f0 Tj9TUcLaPLdmpgnOUOxAV6KSQUuicgpvUAyYIVzSVYioJ/VpY9stcS1P0lx4LqzwqrRq FrUbQ6wDxzAhrsXQwLNZGocadKo/A8/BG4u2G2wvYvWDBck7rBOhh2JzsdjZUgxcdrDH 2ZEFO2Gky1E16UdGg/+ARkVmwklTr/WGWa3xtB4ANohrIMWi8AS6ox2Il+TfF/WszFlx ShxkCahI1VUyd35yQs3ToL6k0I+oRPiGb9lahk6902qMJdNnAx+zDnchGZhoXuTM6eS4 yfYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id co1si3553022edb.571.2020.12.10.12.49.01; Thu, 10 Dec 2020 12:49:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404581AbgLJUqW (ORCPT + 99 others); Thu, 10 Dec 2020 15:46:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732382AbgLJUqV (ORCPT ); Thu, 10 Dec 2020 15:46:21 -0500 Received: from mail.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 710BAC0613CF; Thu, 10 Dec 2020 12:45:41 -0800 (PST) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 617FD4D2ED6E3; Thu, 10 Dec 2020 12:45:40 -0800 (PST) Date: Thu, 10 Dec 2020 12:45:35 -0800 (PST) Message-Id: <20201210.124535.572123178373912255.davem@davemloft.net> To: a@unstable.cc Cc: kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vxlan: avoid double unlikely() notation when using IS_ERR() From: David Miller In-Reply-To: <20201210085549.22846-1-a@unstable.cc> References: <20201210085549.22846-1-a@unstable.cc> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Thu, 10 Dec 2020 12:45:40 -0800 (PST) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Antonio Quartulli Date: Thu, 10 Dec 2020 09:55:49 +0100 > The definition of IS_ERR() already applies the unlikely() notation > when checking the error status of the passed pointer. For this > reason there is no need to have the same notation outside of > IS_ERR() itself. > > Clean up code by removing redundant notation. > > Signed-off-by: Antonio Quartulli Applied to net-next, thanks.