Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp5117008pxu; Thu, 10 Dec 2020 13:25:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyqGByEBxVA7uskulD0VPjiX74W+GAiZXHiOMizgAIz+qTS9m8diMF1iaEpkIVePGOTJVKT X-Received: by 2002:a05:6402:307c:: with SMTP id bs28mr8885621edb.186.1607635501670; Thu, 10 Dec 2020 13:25:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607635501; cv=none; d=google.com; s=arc-20160816; b=0wQO93Jldil651/ADfJcrwpFXntuUaRAO7jTk3Q2pc8gBPNy/1Lc6cSRiDDFsXzaaU o43WDRyDUpDcR2UOqE2dKz6t/TmwG3kWcZ+8hoespBlFWj9FifDDN2RZGeNoHSdv2+zR p/P3Jm/LWNSq5Iqc8Ad829Lft3y5tMtTMNCibmcgA+FP0UocI6TYSXFxaxq32+HXeVZA kS97JMz7mqNR+LHIXNa22evXizsC8YR2ZeZ/xCxKD64lzgoSm8wPHdF8Qdq5H+jNKAte tTmL/Q41SGhN4Eiry25dM7mYEhvWyDdEP+aPlhHveqdCYroz7BMeo643+A43fiGlpB1u fYDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=R8zkvtZZSNWWpGGNIfasxlM2MdKNlc89W/qUwzxXkEI=; b=y/HP6qX13eNAgeEa0cqGYTL58TwgJW8/YM02BPaz/NIqAwBZgy1YVooFkgpFvDJuhz r5q2cBUYqfrxCjtHp8Q9WyU6/bkpnL7MBZFth6YcpGWRIPFt37SbjXaMBKVO1XcZbwS5 LzAYB1qC/na/nDv+mzVzzbM/Hdj4oilMBpGA2FPt/sB0vhOrzNZq+nqa3+6hnBcvoRHd 6MS1OF+yRf+PDk4Rv+J0dxgk0JBHRPTqWznWsVKn3Uu4rdIN/4eY95dkDR7Tj4hXrTWV clAXTWSBUFz3xSNPrZ8GSKw9MNhSQIkDlkPu57oHlkys4g4dQcWF3kXTq+0h6eOK4wDI 1rXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ce21si3833028edb.418.2020.12.10.13.24.38; Thu, 10 Dec 2020 13:25:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404806AbgLJVVj (ORCPT + 99 others); Thu, 10 Dec 2020 16:21:39 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:45692 "EHLO mail.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393867AbgLJVUP (ORCPT ); Thu, 10 Dec 2020 16:20:15 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 44EB74D2ED6E8; Thu, 10 Dec 2020 13:19:24 -0800 (PST) Date: Thu, 10 Dec 2020 13:19:23 -0800 (PST) Message-Id: <20201210.131923.261956317613003321.davem@davemloft.net> To: xie.he.0141@gmail.com Cc: kuba@kernel.org, linux-x25@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ms@dev.tdt.de Subject: Re: [PATCH net-next] net: lapbether: Consider it successful if (dis)connecting when already (dis)connected From: David Miller In-Reply-To: <20201208225044.5522-1-xie.he.0141@gmail.com> References: <20201208225044.5522-1-xie.he.0141@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Thu, 10 Dec 2020 13:19:24 -0800 (PST) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xie He Date: Tue, 8 Dec 2020 14:50:44 -0800 > When the upper layer instruct us to connect (or disconnect), but we have > already connected (or disconnected), consider this operation successful > rather than failed. > > This can help the upper layer to correct its record about whether we are > connected or not here in layer 2. > > The upper layer may not have the correct information about whether we are > connected or not. This can happen if this driver has already been running > for some time when the "x25" module gets loaded. > > Another X.25 driver (hdlc_x25) is already doing this, so we make this > driver do this, too. > > Cc: Martin Schiller > Signed-off-by: Xie He Applied, thank you.