Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp5122533pxu; Thu, 10 Dec 2020 13:34:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJwEhxFn46c4L96u6lQU5z5watqwSyjYKA8rRsvU1T2oGYcHBkoSa73wcMXBA8NqsX8aqBZC X-Received: by 2002:a50:d74c:: with SMTP id i12mr8773270edj.236.1607636085653; Thu, 10 Dec 2020 13:34:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607636085; cv=none; d=google.com; s=arc-20160816; b=O/hrYm7AxeTBUFHXBWffCnU/70J/sP+Tj+vQ4Fk1zVM1H7w2E19An4tihcwN8O5vWb SPk8TlD7GWv/56pPP6kOOj+w3CwEJDT7Q86EMABUjYxNl0SQt2lsHZpMWiuEd8zvhT15 x+LbftUAHkXuRggJOcX1hDCFefAmVK014iOsWMjJ+AQ8Kwk8CLTQEB/X7t7vMXBVQgKl AfSiEgue3PYy4K1gqAjE7NW38t/sta477sabPy+CACnPUboMphFZsSyG/ZlnhAZu81oR 5AgP2cbOwLrzJIRxM+IMHgv5bviZ+t/RXHfwW2quaIeThVn3rqwiFEGBPU7QXHJDcCfd mfIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=CG/7dOEvSUdNXytBKjAMxDPRa39H5tNUPAfrX46RBo4=; b=PLO99jFBYEiQq9IqhroTehYC81mYt6uyiPYh8xn7UQvtNN16xfY9F9kXvExdmISKNd 99y3olveeVQgGYQsugbV4aBRuM3XRk6HUgo30oWCDqJblX7ZIfLGZ3QSsLI3pt4OCqX7 ETRH2ln5Wj6c+4YNl7t7dFUEo5gnmfmVLUbQr2BzzRFDAxTFoFCm/eqljpzNs3wExHYP OuYH3m8Cq9yiT48hMFuFtjdXNdvfa2w7hWiprDKyGcx67R78uCtUYPwPwY8U/KJh9JZr YuqLZJPSTyL41w8L3810t2T6ok4EvLIB+MI+YIk8FIPrgwFwHmOhwqRtoQXFb1h5Bmt6 RhAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gt24si3357239ejb.248.2020.12.10.13.34.22; Thu, 10 Dec 2020 13:34:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405055AbgLJVa6 (ORCPT + 99 others); Thu, 10 Dec 2020 16:30:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:41284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404853AbgLJVaf (ORCPT ); Thu, 10 Dec 2020 16:30:35 -0500 From: Krzysztof Kozlowski Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: Rob Herring , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Lee Jones , Chanwoo Choi , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marek Szyprowski , Sylwester Nawrocki Subject: [PATCH 6/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid XU3 family Date: Thu, 10 Dec 2020 22:29:00 +0100 Message-Id: <20201210212903.216728-6-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201210212903.216728-1-krzk@kernel.org> References: <20201210212903.216728-1-krzk@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. The falling edge interrupt will mostly work but it's not correct. Fixes: aac4e0615341 ("ARM: dts: odroidxu3: Enable wake alarm of S2MPS11 RTC") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi index d0df560eb0db..6d690b1db099 100644 --- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi @@ -509,7 +509,7 @@ pmic@66 { samsung,s2mps11-acokb-ground; interrupt-parent = <&gpx0>; - interrupts = <4 IRQ_TYPE_EDGE_FALLING>; + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&s2mps11_irq>; -- 2.25.1