Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp5125572pxu; Thu, 10 Dec 2020 13:40:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJzYvxqsqpVmm1/maaMl/nRCTZA89qGr6UF609/1lQqM0OXVhb1RI5N3svA2BpTWNY+LhjIu X-Received: by 2002:a05:6402:1696:: with SMTP id a22mr8952506edv.385.1607636414459; Thu, 10 Dec 2020 13:40:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607636414; cv=none; d=google.com; s=arc-20160816; b=QIxbnyFePSTfbz7vTwMg284qa+iPu2aO79JwaI7qCfShR3nh3uNgS7R0h/AEnC3Jgf Pz5HsBwfq6C0eghgnsJ+UOaddJN/htbApfSqXjHSX1KWOTJdeYXTn0JBI+vz3s2fVBjg ZGvUrmPgM0mOM06hVotOEE6YjZCDY0lIqff0rps4WeAQPV+w/eSkAfF5SSfn54lNtpq9 npmoeyHbgsBszt1oH1JpljgX0drRxiOCTnbMfcly3H1SGidyUtNlHTG0F/cPymXhJK7B xkDzKCvhCe/UqNtd3OcFxsYbShpiNzrb4cGawqQf6Zww11J2qxbvteTS+YxuGYc5SCj9 4Hkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8ukUehc8OZbqOIqfZB8mkLlkGyr6BUAJuz1D9jt6nDg=; b=rOEvoPKpyzesfgWfKrIZgCI8nAimo5bK5AY+UMd64b/7JO9wJIVCOnoGd6leHks1sk NKWe/r348KwvDPP3leNZLXV7caIjrR6jceGhZsNilqnmDGuG/MZ2K8ujt+zvESyscObo 10CY5HJdfpChmEA2AwpocSSSWzcJOIrGsMWAiuNja3W9i/d0BNUiyiZGyqry0Igi/A/q SxQ7DQaX4rPEA19tY1SCWRdEoln8rx3k5jQh+yQW/2Ko1RfoR2TuqrhdcR9UBnftMZpI rXtx3lsOnNZv6ZyshbOqoNkq2sAHnWfRnFzwxFKPmooYgHM2mGT6GqlINkhjXST8/NMX 9Tmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u2si3178320ejo.343.2020.12.10.13.39.52; Thu, 10 Dec 2020 13:40:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405018AbgLJVam (ORCPT + 99 others); Thu, 10 Dec 2020 16:30:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:41100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394064AbgLJVaF (ORCPT ); Thu, 10 Dec 2020 16:30:05 -0500 From: Krzysztof Kozlowski Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: Rob Herring , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Lee Jones , Chanwoo Choi , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marek Szyprowski , Sylwester Nawrocki Subject: [PATCH 5/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Arndale Octa Date: Thu, 10 Dec 2020 22:28:59 +0100 Message-Id: <20201210212903.216728-5-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201210212903.216728-1-krzk@kernel.org> References: <20201210212903.216728-1-krzk@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. The falling edge interrupt will mostly work but it's not correct. Fixes: 1fed2252713e ("ARM: dts: fix pinctrl for s2mps11-irq on exynos5420-arndale-octa") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts index bf457d0c02eb..1aad4859c5f1 100644 --- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts +++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts @@ -349,7 +349,7 @@ pmic@66 { reg = <0x66>; interrupt-parent = <&gpx3>; - interrupts = <2 IRQ_TYPE_EDGE_FALLING>; + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&s2mps11_irq>; -- 2.25.1