Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp5128472pxu; Thu, 10 Dec 2020 13:45:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxCHT2wUsmqFiCI1w2ibclzQf5mHmFZU9rxmi2rvFz0uVXBpsI7i+71LKD92pUVME36UQp1 X-Received: by 2002:a17:906:8292:: with SMTP id h18mr8505538ejx.481.1607636747222; Thu, 10 Dec 2020 13:45:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607636747; cv=none; d=google.com; s=arc-20160816; b=XdP9o6730I89E5J5DG0NzxRFYozFnVd7Las6WI5LfKTt3uTACj7j+Znn2thEHoh1zD UK2ts6792ZuqtOljAz8uCerBh1QwmmmCZ93hasUuZnZlycc3OSKc2SxfHgcEnEm6ultz +cT85dzfUkU1FtTd9lR1NDg/wShDW1vmgSOcLSSvhcGW0r7JyMJnbhJs+1Haf5g8AEhn toAMjRCh+CTxTsZlvq89OH2EvZaPdlhWgNRjjSNRq3Ed+V//D+Th7UayTAQyGALwxgfP jmybj5kTOkUrts0OYokS8YbXwnn7yboLiKHq1vzberW2jOmQV182jASyB11ftV8pwPMk sARA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=rKjSAtJkC0aYWx9v3KCJ4UZk8cK+Fvj1EjhwgQ7jsqE=; b=ozwFr6rnMTTX70HtmZJrxa74FvvyCKSZCioIklprJ7HTWKKT7TLRzXVVemAVFS2lme jRTsdw/c5jxfpKKAHLehF2ap57Ulx8OGfXPB4PVDi2Y++QCdiMI6p9SNASjm26UkPB64 3B53om3bJ3oMHu5LG+/4oqafxm3qGjdfwTWEj+COA/1rkzx6pZk49YeF49n7OrDxgX5+ P2uI4/j+N0Ln+oSPgmg77Fv39bXIgkwnWi3EtiV8bO9ufBw+GjUSPAwj2OfJ5ofmrO0o Nb1/RyHY5nUg4yB4S1SWr28p6GpOX2i5K+IhSbgyk4vNiObj0qpZdAq2TJeV+I79H1XJ EHyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a15si3688834eda.177.2020.12.10.13.45.24; Thu, 10 Dec 2020 13:45:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394107AbgLJVnJ (ORCPT + 99 others); Thu, 10 Dec 2020 16:43:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:38414 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404884AbgLJV1T (ORCPT ); Thu, 10 Dec 2020 16:27:19 -0500 From: Krzysztof Kozlowski Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: Chanwoo Choi , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Michael Turquette , Stephen Boyd , Rob Herring , Lee Jones , Sebastian Reichel , Liam Girdwood , Mark Brown , Andy Gross , Bjorn Andersson , Alessandro Zummo , Alexandre Belloni , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Iskren Chernev , Matheus Castello , Sebastian Krzyszkowiak , Angus Ainslie , Hans de Goede Subject: [PATCH 07/18] ARM: dts: exynos: correct PMIC interrupt trigger level on P4 Note family Date: Thu, 10 Dec 2020 22:25:23 +0100 Message-Id: <20201210212534.216197-7-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201210212534.216197-1-krzk@kernel.org> References: <20201210212534.216197-1-krzk@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Maxim PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. Without specifying the interrupt type in Devicetree, kernel might apply some fixed configuration, not necessarily working for this hardware. Additionally, the interrupt line is shared so using level sensitive interrupt is here especially important to avoid races. Fixes: f48b5050c301 ("ARM: dts: exynos: add Samsung's Exynos4412-based P4 Note boards") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-p4note.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi index 5fe371543cbb..9e750890edb8 100644 --- a/arch/arm/boot/dts/exynos4412-p4note.dtsi +++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi @@ -322,7 +322,7 @@ &i2c_7 { max77686: pmic@9 { compatible = "maxim,max77686"; interrupt-parent = <&gpx0>; - interrupts = <7 IRQ_TYPE_NONE>; + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; pinctrl-0 = <&max77686_irq>; pinctrl-names = "default"; reg = <0x09>; -- 2.25.1