Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Dec 2020 13:58:00 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc:     thierry.reding@gmail.com, lee.jones@linaro.org,
        nsaenzjulienne@suse.de, f.fainelli@gmail.com, rjui@broadcom.com,
        sean@mess.org, sbranden@broadcom.com,
        bcm-kernel-feedback-list@broadcom.com, linux-pwm@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] pwm: bcm2835: Support apply function for atomic
 configuration
Message-ID: <20201210125800.gj4f4rioq7df4hbl@pengutronix.de>
References: <1607546905-20549-1-git-send-email-LinoSanfilippo@gmx.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6tvo3blcdefqpmbe"
Content-Disposition: inline
In-Reply-To: <1607546905-20549-1-git-send-email-LinoSanfilippo@gmx.de>
Precedence: bulk


--6tvo3blcdefqpmbe
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 09, 2020 at 09:48:25PM +0100, Lino Sanfilippo wrote:
> Use the newer .apply function of pwm_ops instead of .config, .enable,
> .disable and .set_polarity. This guarantees atomic changes of the pwm
> controller configuration. It also reduces the size of the driver.
>=20
> Since now period is a 64 bit value, add an extra check to reject periods
> that exceed the possible max value for the 32 bit register.
>=20
> This has been tested on a Raspberry PI 4.
>=20
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>

I replied to v3 earlier, this was supposed to go to this v4 of course.
Still had v3 open for comparing the two. So to ensure it is picked up:

Reviewed-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--6tvo3blcdefqpmbe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAl/SG1UACgkQwfwUeK3K
7AlHQQf/Vw6TeRvt4v1Bz3mRlclNw2+/Tcu0VHY8orK2+FYUzUZ4c1ywNmdycxsQ
9FSssC5fW3kLq1rTZnXe0m2dcvj1whY6PIprRo+BSrS5gmF7uc5py5NjstFxA0Z6
aSgMu/L6irP/g8dQUFvzMzSMEhCmqSVqOKGwFGKsMxGbzbp5J6peztQJp0/CxtQo
1G2GGbVKtSnGQsAgO3x3ePXrUj11J9UHtTOSJFDIwIp/DWjm1zatDK4yEsjI2NU1
tdpv2fFpUe/CUfpNqLW31ZJrez8QkJic1LGQ4b/FVbD3LOUQEw7zjDFpGr7XQ5un
xnlbU/YWSJmZ7I77pfLgiZzu2w2iOg==
=DB1h
-----END PGP SIGNATURE-----

--6tvo3blcdefqpmbe--