Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp37860pxu; Thu, 10 Dec 2020 17:32:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJwMxG2Qq0AE5Aa9UTUMWbRdrAzqwfeFQVh/UPmWehQZkrXjkb97yfHAAnuFizZBAht2+BqU X-Received: by 2002:a17:906:b2d1:: with SMTP id cf17mr9196806ejb.281.1607650357647; Thu, 10 Dec 2020 17:32:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607650357; cv=none; d=google.com; s=arc-20160816; b=fAo0b1ywGiushTeRF+OAaR7VA5saO0yB0Z/t8GMzNzWFIT5bGju1Y2IMJS4w9nwC7L ODmJBZNF4C60oqkNH397bGnOE2yQNbagW9CwQ4LSu3PCEHwOMctCEqVTNBgyAxCXM7xv bGTd2fZ8VwBmN815ESuYnuNuzK/fNOEGAUT/P7Vbsek1PyqyIXLURGVc91fmcjIjqz7m VOqey3qBT1xxyVGoRA4asbh4TCkCxK3iAMZBH+6Ldjq3jvr2zQ8T4SIkuUnYypGMb+tr oHjhAti6bbUX+zttH9CktXuMe8VSPfX/uQMlnEYQ8AkPyLMf9j4my+HAFpsXG4C/UgjE /MUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=n8KIpAzt2gJZnUwh0VllZF69sOpithvvV4Pj1HY/ZOM=; b=oRIoRzdZb0flZoGjwa3xX/hxSFIPlSAu5u3JZYQQddypCl79t8TDQztVmMUOTFoQwO QCRSJpi3YhT3xIo/C0bBGNlAgmjvG8ehwSwewEIyDjIJf7ygdEyO0FJvrgFXD+ThBNHN KcbEH1SMit9EzlkuTPbgSgIJBpHNEWwTR+uTe+Q6nE91jB7U3q6hyyZ4dWdOrW6SDEoc m1tLeQUU9wsSgSGtr2sk2ucL+AxW7LtNqIKn4DXb9aWNjFPm/u7FMY97d8Y4M1fvZh5E KaNXwR9Y0Ixl1t1exmJEpRndN3p1+yndQ7FAjx7WoSmexvBUj63E5Ztqc9ragh84k+KW lovw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h24si4060003ejt.583.2020.12.10.17.32.15; Thu, 10 Dec 2020 17:32:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391086AbgLJOhd (ORCPT + 99 others); Thu, 10 Dec 2020 09:37:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:42288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389443AbgLJOeM (ORCPT ); Thu, 10 Dec 2020 09:34:12 -0500 From: Greg Kroah-Hartman Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Luo Meng , Hans de Goede , Dmitry Torokhov Subject: [PATCH 4.19 37/39] Input: i8042 - fix error return code in i8042_setup_aux() Date: Thu, 10 Dec 2020 15:27:16 +0100 Message-Id: <20201210142604.116728762@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201210142602.272595094@linuxfoundation.org> References: <20201210142602.272595094@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luo Meng commit 855b69857830f8d918d715014f05e59a3f7491a0 upstream. Fix to return a negative error code from the error handling case instead of 0 in function i8042_setup_aux(), as done elsewhere in this function. Fixes: f81134163fc7 ("Input: i8042 - use platform_driver_probe") Reported-by: Hulk Robot Signed-off-by: Luo Meng Reviewed-by: Hans de Goede Link: https://lore.kernel.org/r/20201123133420.4071187-1-luomeng12@huawei.com Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/serio/i8042.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/input/serio/i8042.c +++ b/drivers/input/serio/i8042.c @@ -1472,7 +1472,8 @@ static int __init i8042_setup_aux(void) if (error) goto err_free_ports; - if (aux_enable()) + error = aux_enable(); + if (error) goto err_free_irq; i8042_aux_irq_registered = true;