Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp228434pxu; Fri, 11 Dec 2020 00:26:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJxppCn5vGUalt8nlI5KqSjr7dNsYWmyPrL7brFAWO9g/LTclP8Wo8fpB/UOAbGb6ErNCEcm X-Received: by 2002:a17:906:77c5:: with SMTP id m5mr9591013ejn.424.1607675166681; Fri, 11 Dec 2020 00:26:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607675166; cv=none; d=google.com; s=arc-20160816; b=qR03WV++rLd4HSEIr1o9QtOclVMXGetTIpzMTxoXwfd04lbNel20shW9B7byCRTZi+ d2cAP/3nKH2Uy6JUih+MYciR9C92G990dEgRo1ez+KCjLP9nkWit3O0GVm4O6G01AOfm KdNUsF9bfEYpvnGNsrS1hqlfHfAcvnB85686GiMOtOBHvZUf27tR05Inzr5dBl8+Vubl ML7bh0WCRaU0yDFX3QvSmt85dn5lm+i4k/ZvdZfxWGPQ3F5J52WYBI3i5sfYilPTbAlt eJjtdUabZNSd96mbzYWbD8T3CewtltfBmNJkavAiPe4Nuc/P/tFrmA4DtjH+BH/gasoB D8Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9EEM0AX878xSa8V2cvUDpTLDczQ0IGzyz0LRReW9tzA=; b=HXP1vCJBefH5l2teg6c5c7P9kLiVIJO8MRmR/CMpwXSTIU3GdYadTNq19358h/7Dod +GCzNrYRaQrKdKwPQey0ipMefP/1t0ZKzoa33mpaA2RtWazjCWomcd3DJEDn1VxgPDo+ fFUbKyXhThR/Rfu6U1NvV1+YMmWgEUYCD/olzXeqQlz8SiqKZGlCYiuim369Zuj/Ldhy bB4Zy4iEPuQLS7AJMJvAAIfoXPzyqOsEvwGbxzruhT2jP1rkg5vv3R9p+Uq7qbCrtqdC raLmNlNjcjrKcH1NqtpQk2Mvgw6D2Y0p1f+izrra7pW6IVldyqVBxAUsWB8VHEPLPzbl S8Rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=dG3nDfcS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a7si4291778edj.215.2020.12.11.00.25.42; Fri, 11 Dec 2020 00:26:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=dG3nDfcS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728423AbgLJQTm (ORCPT + 99 others); Thu, 10 Dec 2020 11:19:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392280AbgLJQHD (ORCPT ); Thu, 10 Dec 2020 11:07:03 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8D71C061793 for ; Thu, 10 Dec 2020 08:06:20 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id c5so2405066wrp.6 for ; Thu, 10 Dec 2020 08:06:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9EEM0AX878xSa8V2cvUDpTLDczQ0IGzyz0LRReW9tzA=; b=dG3nDfcSFKcJqfMUlDBawK6U+/17xUIuG5w7oEcJKBYdW1zerFAMxTR27Vw3ED9rWV aZ5xpsrUl1k/73I4w1FR6llyHh342rQEBBSuerrIpeeWaTwd0YgiGKLpWIRVtTWvd0Vr OvEPfWDYhl0k31LxHGSu2Y79gbq2+C/UQRm4+nfafn5ylsnB1sL/jMp6VoQ1CSC8wFkX TGklkiZNfuDYk9kbL+3VXuWSYYQ0/jsni1x+f55I0oy0LfaTM5ZgzIiw6+vZ2IaGg5TV VkN2qdkxGVbKvtdqLvrMGA2oN0cFpRSU6eGeFz2VAY046PYj+H8zuJcV2RZuDHBwQt/o VW3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9EEM0AX878xSa8V2cvUDpTLDczQ0IGzyz0LRReW9tzA=; b=E1VDMqRRz5o9x+/fEl/gDB5bfLN9fSG4sxkcH5xtSqLyoW4XqJoykMkipviMOy5Scw G+pyL1qC1XANKwn3g2JhGWckAPRWwetn0CDCeOlXIPt9fkonKpvv4ghmSdgZ7OROX7qj 5SKHnmk3/VfSIiiTRKfPEpEFrM5T1P4yfzZUROBoNQdzRiOg3TnS9jS5QLUugFmc0fdX x9FM81uFB7xbGBH4+1P/4SON78cd6IzTYmU+f0S+T/cvsesxvDFOGH1MPYIAiVV5rWk1 oLcD8Y+87t5r6+pPWOTN5DB101dINk3amckdqRQi+f8BK+BWkjExwVM4txrz76XVxmcc p8Rg== X-Gm-Message-State: AOAM5332xM9TK4WHLa1Zdl1QKvtRQ9i8BRvu7FrfMbE93P7FY9+a+39y 8Xwtfpam6f7jUq18QrbvA/Iydg== X-Received: by 2002:adf:9124:: with SMTP id j33mr8598967wrj.376.1607616379710; Thu, 10 Dec 2020 08:06:19 -0800 (PST) Received: from localhost (p4fdabc80.dip0.t-ipconnect.de. [79.218.188.128]) by smtp.gmail.com with ESMTPSA id x7sm2719625wmi.11.2020.12.10.08.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Dec 2020 08:06:19 -0800 (PST) Date: Thu, 10 Dec 2020 17:04:13 +0100 From: Johannes Weiner To: Muchun Song Cc: gregkh@linuxfoundation.org, rafael@kernel.org, adobriyan@gmail.com, akpm@linux-foundation.org, mhocko@kernel.org, vdavydov.dev@gmail.com, hughd@google.com, will@kernel.org, guro@fb.com, rppt@kernel.org, tglx@linutronix.de, esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, surenb@google.com, avagin@openvz.org, elver@google.com, rdunlap@infradead.org, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org Subject: Re: [RESEND PATCH v2 01/12] mm: memcontrol: fix NR_ANON_THPS account Message-ID: <20201210160413.GH264602@cmpxchg.org> References: <20201206101451.14706-1-songmuchun@bytedance.com> <20201206101451.14706-2-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201206101451.14706-2-songmuchun@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 06, 2020 at 06:14:40PM +0800, Muchun Song wrote: > The unit of NR_ANON_THPS is HPAGE_PMD_NR already. So it should inc/dec > by one rather than nr_pages. > > Fixes: 468c398233da ("mm: memcontrol: switch to native NR_ANON_THPS counter") > Signed-off-by: Muchun Song Acked-by: Johannes Weiner But please change the subject to 'mm: memcontrol: fix NR_ANON_THPS accounting in charge moving'