Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <91b4b2f3591e6e8ce2d61daae31f2218d1a12b9e.camel@perches.com>
Subject: Re: [RFC PATCH v2] checkpatch: rewrite Kconfig parsing
From:   Joe Perches <joe@perches.com>
To:     Nicolai Fischer <nicolai.fischer@fau.de>,
        linux-kernel@vger.kernel.org
Cc:     apw@canonical.com, johannes.czekay@fau.de,
        linux-kernel@i4.cs.fau.de
Date:   Thu, 10 Dec 2020 14:20:12 -0800
In-Reply-To: <d97d491e-10fe-5c2e-ebdd-45f437afd257@fau.de>
References: <a07d684c-37ea-b589-c4b1-489e88b5caa5@fau.de>
         <97fb4ba0-68b3-8faf-1d98-e4990b2e63e3@fau.de>
         <776550b7fac3870e65e903f0d8cb917dec58f7c2.camel@perches.com>
         <d97d491e-10fe-5c2e-ebdd-45f437afd257@fau.de>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2020-12-09 at 15:24 +0100, Nicolai Fischer wrote: 
> We understand that checkpatch may not be the ideal place for all of these checks.

So please work on an ideal thing.

> However the current implementation has some problems we would like to fix.
> Would you be interested in a patch series addressing just the check for the number of lines?
> Specifically:
> 1)
> > 
> > > 
> > > I believe all the '---help---' lines have been converted to just 'help'
> > > so the '(?:---)?' bits here could be removed.
> > 
> > Yes.
> > 
> 2) add string, hex and int types to the $is_start regex

sure

> 3) improve the help message to include the number of present and expected lines

no.  The concept of a required paragraph is still dubious.

> 4) Warn if help text is not followed by a blank line or endif

How often is it now not followed by a blank line or endif?