Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Dec 2020 17:47:58 -0800 (PST)
Subject:     Re: [PATCH] riscv: Fixed kernel test robot warning
In-Reply-To: <871rg0cajt.fsf@igel.home>
CC:     jrdr.linux@gmail.com, Paul Walmsley <paul.walmsley@sifive.com>,
        aou@eecs.berkeley.edu, guoren@linux.alibaba.com,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
From:   Palmer Dabbelt <palmer@dabbelt.com>
To:     schwab@linux-m68k.org
Message-ID: <mhng-0e645b05-d32f-42ea-874a-4c91273f5bb6@palmerdabbelt-glaptop1>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 08 Dec 2020 12:22:46 PST (-0800), schwab@linux-m68k.org wrote:
> On Dez 09 2020, Souptick Joarder wrote:
>
>> On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>>>
>>> On Dez 09 2020, Souptick Joarder wrote:
>>>
>>> > Kernel test robot throws below warning -
>>> >
>>> >    arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
>>> > for 'asm_offsets' [-Wmissing-prototypes]
>>> >       14 | void asm_offsets(void)
>>> >          |      ^~~~~~~~~~~
>>> >
>>> > This patch should fixed it.
>>>
>>> Or rename it to main, like most other asm-offsets files.
>>
>> Few asm-offsets files named it as foo(). Does a rename to main() will
>> work straight forward ?
>
> Calling it main will suppress the warning, but other than that it is
> completely irrelevant how you call it.

Ya, I think it doesn't really matter so I'm just going to take this as is.
It's on for-next (being a bit paranoid, as we're so late in the cycle).