Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Liu Ying <victor.liu@nxp.com>
To:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org
Cc:     kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
        a.hajda@samsung.com, narmstrong@baylibre.com,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@siol.net, airlied@linux.ie, daniel@ffwll.ch,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org,
        robert.chiras@nxp.com, martin.kepplinger@puri.sm
Subject: [PATCH v3 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable()
Date:   Fri, 11 Dec 2020 09:46:18 +0800
Message-Id: <1607651182-12307-2-git-send-email-victor.liu@nxp.com>
In-Reply-To: <1607651182-12307-1-git-send-email-victor.liu@nxp.com>
References: <1607651182-12307-1-git-send-email-victor.liu@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost.localdomain (119.31.174.66) by SG2P153CA0042.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3676.5 via Frontend Transport; Fri, 11 Dec 2020 01:54:42 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: bc22d55c-db69-412b-3f22-08d89d77bdaa
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3952:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0402MB3952992F080F6F5CBC90014598CA0@VI1PR0402MB3952.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2201;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YawtK11IMTjcTjvC1VXb+ZtgHyfVT6PktdNPo9O0Ud4iS/5LQukSrpVHMrlZEhS1LJS9juuruQEzvpv2IAX3M4dAzc/mp3bwPCnc8BixbkzLOGgk9C0Px5dpPLAaOMEX2Z7yOuHY+/+VIE71gFPH81Ij4W49aM2yeB/8GZZgq92OYLoHoZJ56K1JXmloeZWaS8FomfZ2wKPXWfrC6+H0PGhfiGHK0vBjr0rixfGoMlbBa23ZneDrRGZNC51lhccsNBNuwQIceeddDe0Jbip2w7u5R6nr5XdPM6tO8FDAmimZOe5YtYdlXgP62Q37J+XaFgE7Yv3gDRmO3+SN6o4K9g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB3983.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(376002)(39860400002)(346002)(366004)(52116002)(316002)(956004)(2616005)(5660300002)(66556008)(4326008)(66476007)(2906002)(66946007)(6512007)(7416002)(8676002)(16526019)(26005)(186003)(8936002)(6486002)(36756003)(478600001)(86362001)(6666004)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?K2thcWJqTlFESVQ5b250aTJPVEFaeG5MRzZhbk5DVkk0UG96eTdpYUhGYUV1?=
 =?utf-8?B?YnFwNVVna3RUVkNyNzBsbWVOZmNyWFVacDVXbDEzWnkzVUI0R2t0OTJQdVlF?=
 =?utf-8?B?T1A5MHFhbm4xYTk1UFA3M3BhQk1jd3dYYmFEa05LTHFPa1gxVEFWd3lpcFFt?=
 =?utf-8?B?a1JmaFZsV1dlSEFhQktxSXpEcWFVQUVoZWUvSkRacng0OHdJTzhIN2VxOWRB?=
 =?utf-8?B?MmljUE12SVlxTGEvaEpzdFcraW5TSlp6d1FKa2pjUVZCN3g5aXRHU1RVZDhI?=
 =?utf-8?B?WXJJaFVQN2VpODFPamROaE1UbHFTQ2tJNTlnaEF2cHhiUHNTWFRxUGRlQTRt?=
 =?utf-8?B?djN2R2UxUHN0MVZwMGhWTzhyV0dDaGNOZ1BqRGlxQU5rMTZZbUFUajk4NFp3?=
 =?utf-8?B?dkVEYkpmY0FqMUZMc2RIT0ovQU5IMW5VenpzR0JMVjdqQWZqR1orL0VmVVJP?=
 =?utf-8?B?WjN2U2lNb3NiZmU1TXZZUUUzWnJXVWlrNytMWFZTTS8zc3E4a1FWL2VoV3cx?=
 =?utf-8?B?dVowMDVDcHZSMzZRVTI5SmU0VExxdEQrVHM1RUJQWmVheUIwMG1NdDNPbVdi?=
 =?utf-8?B?djlEelZYalFlRGNzNG1RMlRDWXFtb09nQWFldEJCMWRBSHJza1d5aVNudzBm?=
 =?utf-8?B?a1JZSGw1K3grQjF5SzZTck43Y1FCcVJqNjdlWll3bjFvTmVDS0VqeHhRSnFw?=
 =?utf-8?B?eU9QWlNMTUJrMVl5NHNDS0FJUTJxRmhlbFlwTDZDVW1OaG05UzJhME5TckVj?=
 =?utf-8?B?RGR5OTBreVJabVh1T2g5VzdXbkI1WkZRYVZrUTBYUEMxMzBZN3F1TlUyZXl4?=
 =?utf-8?B?b1NYcHlBYWpjeEtRNFJxQkRBOXVJSyswdzNYaXpPRUxIZHJtRGc0eE84bFdX?=
 =?utf-8?B?N0ZqS0tzVlNYcEF6aW1yZTlhcm05NmhVT0FpSjZhOWI5ekcxa0FWbmRmc3I4?=
 =?utf-8?B?ZGZzR2VrK0xTQ3BYVkRFWXNQUjYwdG5IeWRUU2Z2VHJtUlJpRGVMNklnblVB?=
 =?utf-8?B?ck9oYnFjM0JrSW5pMVdDdGdiajk0eURZSUh5SVZGeXIyUlFaandyVUJUem84?=
 =?utf-8?B?TFlzTE1UakNSTUtiMVFhaEdSUzFES2lVVXgvaTUyelZxa2QrT2I1WFpHNmNx?=
 =?utf-8?B?NVMzNG5xT2tiN1M5MjN6TThXOVZtdE81RHJuY0FnUHFacXV0bzJML1cxcmU1?=
 =?utf-8?B?VjlUbmJNNDRvTUN0YlJFcG5QU1JXUFNMbUNHVW9WOXFmWjJwa0NGczVsb1dB?=
 =?utf-8?B?b2U3eDZqWUJkZTU0dFo0dGliQ1R2SkZXVXpPcitoR0EvSG9ocTExdVI3Ujg3?=
 =?utf-8?Q?cxg076Lc9WZHX8DqWhR7fzrgDWcWwLJL01?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3983.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2020 01:54:47.8846
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-Network-Message-Id: bc22d55c-db69-412b-3f22-08d89d77bdaa
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c4Ft0Plr/xtyJRrxoICZ2Z2hTPmf2fhUWDkpSwdc0gLjH5tVHSw1RZLCjVLmzPz2b104fnRoNqpmV0EIauOJxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3952
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp
works with a Mixel MIPI DPHY + LVDS PHY combo to support either
a MIPI DSI display or a LVDS display.  So, this patch calls
phy_set_mode() from nwl_dsi_enable() to set PHY mode to MIPI DPHY
explicitly.

Cc: Guido Günther <agx@sigxcpu.org>
Cc: Robert Chiras <robert.chiras@nxp.com>
Cc: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: NXP Linux Team <linux-imx@nxp.com>
Reviewed-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v2->v3:
* No change.

v1->v2:
* Add Guido's R-b tag.

 drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
index 66b6740..be6bfc5 100644
--- a/drivers/gpu/drm/bridge/nwl-dsi.c
+++ b/drivers/gpu/drm/bridge/nwl-dsi.c
@@ -678,6 +678,12 @@ static int nwl_dsi_enable(struct nwl_dsi *dsi)
 		return ret;
 	}
 
+	ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY);
+	if (ret < 0) {
+		DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", ret);
+		goto uninit_phy;
+	}
+
 	ret = phy_configure(dsi->phy, phy_cfg);
 	if (ret < 0) {
 		DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret);
-- 
2.7.4