Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     David Laight <David.Laight@ACULAB.COM>
CC:     'Daniel Thompson' <daniel.thompson@linaro.org>,
        "linux-netdev@vger.kernel.org" <linux-netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD
 instead of realloc-ing
Thread-Topic: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD
 instead of realloc-ing
Thread-Index: AQHWzxpfkmhJ4/PRJUyjg6gvz97H0KnxomOAgAACSwA=
Date:   Fri, 11 Dec 2020 09:38:57 +0000
Message-ID: <20201211093856.gj3do6ntnmxsqtzp@skbuf>
References: <20200629184712.12449-2-ioana.ciornei () nxp ! com>
 <20201210173156.mbizovo6rxvkda73@holly.lan>
 <c4e033fe17674685b64a60055c68704e@AcuMS.aculab.com>
In-Reply-To: <c4e033fe17674685b64a60055c68704e@AcuMS.aculab.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CB5C63B8D8D11C4AAC6FD948600CC2DC@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: dc44db53-01fd-4db0-e544-08d89db89527
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2020 09:38:57.3399
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vZ48qIuBPOsanLKPpaZFTnjqqCzZpQ8Iz6UT9hkqZhIzIwd1pd4rSPmvmxuf5ZbKMYV6ATnotcvjj8vEvZse9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4128
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 11, 2020 at 09:30:43AM +0000, David Laight wrote:
> From: Daniel Thompson
> > Sent: 10 December 2020 17:32
> >=20
> > On Mon, Jun 29, 2020 at 06:47:11PM +0000, Ioana Ciornei wrote:
> > > Instead of realloc-ing the skb on the Tx path when the provided headr=
oom
> > > is smaller than the HW requirements, create a Scatter/Gather frame
> > > descriptor with only one entry.
>=20
> Is it worth simplifying the code by permanently allocating (and dma-mappi=
ng)
> the extra structure for every ring entry.
> It is (probably) only one page and 1 iommu entry.


That is exactly what I was thinking. At the moment the SGT structure is
pre-allocated but not pre-mapped.

I'll let you know how it goes.

Ioana=