Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: MI4V0kcGBonKH93xbf53zoSbesfDet9EXFVyleeSSKofQnS34Aa4LPZ3LEe2BEjMD8Z5/9lUC+
 Nme4D72B+/ww==
IronPort-SDR: RMW2Ki7emK7l8an+qXvRupYs81QsytOeYL+kwKXoe+tyPTgdInZAjLEK/FfJGkLulkLN7+I4yr
 kxS+GKoUI/TA==
From:   "Kelly, Seamus" <seamus.kelly@intel.com>
To:     Joe Perches <joe@perches.com>,
        "mgross@linux.intel.com" <mgross@linux.intel.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>, "bp@suse.de" <bp@suse.de>,
        "damien.lemoal@wdc.com" <damien.lemoal@wdc.com>,
        "dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "leonard.crestez@nxp.com" <leonard.crestez@nxp.com>,
        "palmerdabbelt@google.com" <palmerdabbelt@google.com>,
        "paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
        "peng.fan@nxp.com" <peng.fan@nxp.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        Ryan Carnaghi <ryan.r.carnaghi@intel.com>
Subject: RE: [PATCH 16/22] xlink-ipc: Add xlink ipc driver
Thread-Topic: [PATCH 16/22] xlink-ipc: Add xlink ipc driver
Thread-Index: AQHWyDJBAHRzyzcAgEmZdZQ/FXOFKKnq8huAgAbgG5A=
Date:   Fri, 11 Dec 2020 11:33:02 +0000
Message-ID: <BYAPR11MB37839DDCA13DC55E594F5D108ACA0@BYAPR11MB3783.namprd11.prod.outlook.com>
References: <20201201223511.65542-1-mgross@linux.intel.com>
         <20201201223511.65542-17-mgross@linux.intel.com>
 <d33f6b90d50feb6c05bd45ffdedf3fb6d5ceb5ee.camel@perches.com>
In-Reply-To: <d33f6b90d50feb6c05bd45ffdedf3fb6d5ceb5ee.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fbabe34-74ef-4575-a4aa-08d89dc8853a
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2020 11:33:02.5199
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jrcMit2HeEydqTv+beBI/PGt5zC5AyLKybrpdlShhId6mZfGFWYc3M9fwipIT5XrZXNleIP76yorhWRJsOaSmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3045
X-OriginatorOrg: intel.com
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


From: Joe Perches <joe@perches.com> =

Sent: Monday, December 7, 2020 2:33 AM
To: mgross@linux.intel.com; markgross@kernel.org; arnd@arndb.de; bp@suse.de=
; damien.lemoal@wdc.com; dragan.cvetic@xilinx.com; gregkh@linuxfoundation.o=
rg; corbet@lwn.net; leonard.crestez@nxp.com; palmerdabbelt@google.com; paul=
.walmsley@sifive.com; peng.fan@nxp.com; robh+dt@kernel.org; shawnguo@kernel=
.org
Cc: linux-kernel@vger.kernel.org; Kelly, Seamus <seamus.kelly@intel.com>; l=
inux-doc@vger.kernel.org; Ryan Carnaghi <ryan.r.carnaghi@intel.com>
Subject: Re: [PATCH 16/22] xlink-ipc: Add xlink ipc driver

On Tue, 2020-12-01 at 14:35 -0800, mgross@linux.intel.com wrote:
> From: Seamus Kelly <seamus.kelly@intel.com>
> =

> Add xLink driver, which interfaces the xLink Core driver with the Keem =

> Bay VPU IPC driver, thus enabling xLink to control and communicate =

> with the VPU IP present on the Intel Keem Bay SoC.

Trivial style comments:

> diff --git a/drivers/misc/xlink-ipc/xlink-ipc.c =

> b/drivers/misc/xlink-ipc/xlink-ipc.c

[]

> +/*
> + * xlink_reserved_memory_init() - Initialize reserved memory for the dev=
ice.
> + *
> + * @xlink_dev:	[in] The xlink ipc device the reserved memory is allocate=
d to.
> + *
> + * Return: 0 on success, negative error code otherwise.
> + */
> +static int xlink_reserved_memory_init(struct xlink_ipc_dev =

> +*xlink_dev) {
> +	struct device *dev =3D &xlink_dev->pdev->dev;
> +
> +	xlink_dev->local_xlink_mem.dev =3D init_xlink_reserved_mem_dev(dev,
> +								     "xlink_local_reserved",
> +								     LOCAL_XLINK_IPC_BUFFER_IDX);
> +	if (!xlink_dev->local_xlink_mem.dev)
> +		return -ENOMEM;

This sort of code, with a repeated struct dereference, generally reads bett=
er using a temporary and is also less prone to typo use.

	struct device *dev =3D &xlink_dev->pdev->dev;
	struct xlink_buf_mem *lxm =3D &xlink_dev->local_xlink_mem;

	lxm->dev =3D init_xlink_reserved_mem_dev(dev, "xlink_local_reserved",
					       LOCAL_XLINK_IPC_BUFFER_IDX);
	if (!lxm->dev)
		return -ENOMEM;

> +	xlink_dev->local_xlink_mem.size =3D get_xlink_reserved_mem_size(dev,
> +								      LOCAL_XLINK_IPC_BUFFER_IDX);

	lxm->size =3D get_xlink_reserved_mem_size(dev, LOCAL_XLINK_IPC_BUFFER_IDX);

etc...

[Kelly, Seamus] Thank you!  will do.


--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the s=
ole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact =
the
sender and delete all copies.