Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Anand Ashok Dumbre <ANANDASH@xilinx.com>
To:     Jonathan Cameron <jic23@kernel.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>
CC:     Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Michal Simek <michals@xilinx.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: RE: [PATH v3 0/3] iio: adc: xilinx: use even more devres
Thread-Topic: [PATH v3 0/3] iio: adc: xilinx: use even more devres
Thread-Index: AQHWx1Zf70/YCanXOUOBVqqdgaT4Wanx09Qg
Date:   Fri, 11 Dec 2020 12:15:15 +0000
Message-ID: <BY5PR02MB6916FD4844C5471C635DAD1AA9CA0@BY5PR02MB6916.namprd02.prod.outlook.com>
References: <20201130142759.28216-1-brgl@bgdev.pl>
 <20201130202110.62e7f989@archlinux>
In-Reply-To: <20201130202110.62e7f989@archlinux>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d940e899-b65c-47a8-6f37-08d89dce6b3a
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2020 12:15:15.9137
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PmSVX7zEBhbcQT7FBOaSkGk/qqTMNjnV+vmLrw/zHkOyXCqgqK2rXJzouCp0L6aY3O+fMVNp7nfETzRpinSEUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7247
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Jonathan Cameron <jic23@kernel.org>
> Sent: Monday 30 November 2020 8:21 PM
> To: Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-Stadler
> <pmeerw@pmeerw.net>; Michal Simek <michals@xilinx.com>; linux-
> iio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Bartosz Golaszewski
> <bgolaszewski@baylibre.com>; Anand Ashok Dumbre
> <ANANDASH@xilinx.com>
> Subject: Re: [PATH v3 0/3] iio: adc: xilinx: use even more devres
>=20
> On Mon, 30 Nov 2020 15:27:56 +0100
> Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>=20
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > This is a follow-up to commit 750628c79bb1 ("iio: adc: xilinx-xadc:
> > use devm_krealloc()"). I noticed we can use even more devres helpers
> > and entirely drop the remove() callback.
> >
> > v1 -> v2:
> > - squash three patches adding more devres calls into one for easier
> > review
> > - don't insist on the 80 characters limit
> > - add a new helper: devm_krealloc_array() and use it
> >
> > v2 -> v3:
> > - drop the devm_krealloc_array() helper
> >
> > Bartosz Golaszewski (3):
> >   iio: adc: xilinx: use helper variable for &pdev->dev
> >   iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc()
> >   iio: adc: xilinx: use more devres helpers and remove remove()
> >
> >  drivers/iio/adc/xilinx-xadc-core.c | 157
> > ++++++++++++++---------------
> >  1 file changed, 74 insertions(+), 83 deletions(-)
> >
>=20
> Series looks good to me but would like to leave it a little longer to let=
 others
> take a look at it. That will probably mean it falls into next cycle now.
>=20
> +CC Anand who is looking at another series touching this driver and
> +might
> give this one a spin as well.
>=20
> Thanks,
>=20
> Jonathan

Hi Jonathan, Bartosz,

I have tested and reviewed the patch and everything looks good.
I have another patch series on the same files that might cause conflicts.

Reviewed-by: Anand Ashok Dumbre <anandash@xilinx.com>
Tested-by: Anand Ashok Dumbre <anandash@xilinx.com>

Thanks,
Anand