Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Dec 2020 14:04:13 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Adrien Grassein <adrien.grassein@gmail.com>
Cc:     lgirdwood@gmail.com, robh+dt@kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        troy.kisky@boundarydevices.com, gary.bisson@boundarydevices.com
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: add pf8x00 PMIC
Message-ID: <20201211140412.GD4929@sirena.org.uk>
References: <20201206002629.12872-1-adrien.grassein@gmail.com>
 <20201210221629.17312-1-adrien.grassein@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="rz+pwK2yUstbofK6"
Content-Disposition: inline
In-Reply-To: <20201210221629.17312-1-adrien.grassein@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--rz+pwK2yUstbofK6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Dec 10, 2020 at 11:16:28PM +0100, Adrien Grassein wrote:
> Add a devicetree binding documentation for the pf8x00 regulator driver.

Please don't send new patches in reply to old threads, it makes it hard
to keep track of what is going on.

> +          regulator-name:
> +            pattern: "^ldo[1-4]$"
> +            description:
> +              should be ldo1", ..., "ldo4"

This is part of the generic regulator binding and since it's for board
specific usage it should not be constrained by the chip binding.

> +          nxp,vselect-en:
> +            $ref: /schemas/types.yaml#definitions/flag
> +            description:
> +              Only available for ldo2. When specified, use the VSELECT
> +              input pin of the chip to control the output voltage of the
> +              ldo02 regulator. (3.3V if VSELECT is LOW, 1.8V if HIGH).

How is VSELECT used without a binding specifying some mechanism for
control?

> +          nxp,ilim-microamp:
> +            $ref: /schemas/types.yaml#definitions/uint32
> +            minimum: 2100
> +            maximum: 4500
> +            default: 2100
> +            enum: [ 2100, 2600, 3000, 4500 ]
> +            description:
> +              Defines the maximum current delivered by the regulator in microamp.

Instead of implementing a custom property this should use the already
existing properties for current limits, this is a common thing for
hardware to have so we shouldn't have custom bindings.  We'll need to
relax the check the code currently has for a non-zero minimum limit but
otherwise everything should already be there.

--rz+pwK2yUstbofK6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/TfFwACgkQJNaLcl1U
h9DHmQf+J6eBS3ktnfdMA7vXj4vjK4zc06b/pJOkkkFUd9RlEBtYcAYUBX2Lr5Tg
C/pRbwGf5xwcNKbC87vxoJh9SyhPWPUTgvK/LmTKKoUOov4PGvNd4toEZtCrs8hy
OBSy4rrVgsEArZ698WJvoH83kbAurE9OOSU7jfgwPh+LpFyMSp2InRKk18vfPgxF
kDad/QJAteAgFNC5CQf9iFdpjszDFOYzalddv6Xwta2gcT9Q0HEVFHPmloeZ4wrd
IKD3iQhHFcHB6gjn4rADutEec1g7nmvm7HGNVWC5qCg543Fdqm5V6KmBBpoJXL8E
ZLEfOz8aqoo+YZhjEzQQJfqVG51Vdg==
=w27h
-----END PGP SIGNATURE-----

--rz+pwK2yUstbofK6--