Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp466748pxu; Fri, 11 Dec 2020 06:40:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJze/qsPKNpqUheg5fZzpBgLKYZr3ZCN+4b33UAzYH6nxCWUOsjD07/eIJvyqPkG31fgWJ2i X-Received: by 2002:a50:becf:: with SMTP id e15mr12524097edk.138.1607697628282; Fri, 11 Dec 2020 06:40:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607697628; cv=none; d=google.com; s=arc-20160816; b=IDDTOIoEfZLVHrxWzrviRyx8h70oMOgoO0kLkobDDRbaep4HtXbkq3KlL2nRUBIVtM 94jahO21DEjF+YbZf1WMDV19tW+KUg7ybT4SbBmW5zpQxWCXMDVOXWNOnTlL5sEcKAec 4COQ9QkUY8+qvquNkYNdrrTPXqKWlGWBRVsOuHPIoRqhEVmfCU16whZtjSmtJAYB4x/I 3EGGAOXUkYGuYy+P+jXl6TEG5U/zbjPPwURIgJcBvBlOdYSooacAMtOdO+mow0DzXYzs Nxu8c6KqBX8f8t/msN8zYKvWCrof9n/OXf+cONm4TbUnzyB72BexwohrDzaGmvmdhXOL E8/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=1hvkBnuTRFKVp4hIMELee8T2SRcywd+sthSvyux1z8M=; b=RuukPcSsc84nHplZNCzKF0QLhgK1LzpoOHURCbFysVIK+z79AUA2e3VcAz0gP+ghKn IRSXuAtKicWKCAkltQHS4z0cxLldmJotN/bqzehHcyATEiunSErn6phfmHT0YBDgZjWA Igz/dKTAh6e2K6jM8G2vv/ZOcy2j75dDeftkd3aQCtnfrgkvnu1YSn+MO+8Fblm8H/MP JBrW3q+vfdIPDrcfYphnIF1kBFravbP/bKsyoxKgXpdScCP/nMb4Dl/EqVbgEHrAH4aq agLyBqKRQfb2WL9idJDEMcft6KGOOh2mgN4O5Nqcb+01uuqwat8rbdiu0KIppNJZyOz5 UF3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c23si4558210ejx.330.2020.12.11.06.40.05; Fri, 11 Dec 2020 06:40:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394795AbgLKODZ (ORCPT + 99 others); Fri, 11 Dec 2020 09:03:25 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:41852 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395045AbgLKOCW (ORCPT ); Fri, 11 Dec 2020 09:02:22 -0500 Received: by mail-wr1-f67.google.com with SMTP id a12so9135176wrv.8; Fri, 11 Dec 2020 06:02:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1hvkBnuTRFKVp4hIMELee8T2SRcywd+sthSvyux1z8M=; b=hu263V2i2DT2JybAT5Mo8HH01HKuoiJvqQknviwfKGaj7V9drXbrzsL5sWCyzrO0M3 nxLIwh7IgnsXY9Rh3PL3nK7sbG6cHYAWDJqRy5wELqglUauDbZgj1qAk4x7GI/Y3PjyN fXByk/yna+myR1U/wsdePUzG5wlpo/g774OpAtASBKL3eNjpdHDd0T8cTX0qiARUJ/+x cXbq7zO7oXXAypcKV2O7HAWmSp0C1QmcC1BU5vSZr8BCyWgAVI3Iysul32+5zGqdhDna 95z1KwUJhOIgmlT5dm1mLGdk+wZ3LU/nNqLRprJ0xn/FA11Y3gPRflflPZKJkFEO7PKx EcIQ== X-Gm-Message-State: AOAM531u6sSzRsABMknKS8AaiPldI4G1ozgpB5ImXWAuTAN5t8eNc2hM gAJd6JX12gB7M7vtWUg+QsaAq9bYLZY= X-Received: by 2002:adf:8b5a:: with SMTP id v26mr6360906wra.138.1607695300661; Fri, 11 Dec 2020 06:01:40 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id c129sm14736891wma.31.2020.12.11.06.01.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 06:01:39 -0800 (PST) Date: Fri, 11 Dec 2020 14:01:37 +0000 From: Wei Liu To: "Andrea Parri (Microsoft)" , "Martin K. Petersen" Cc: linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Michael Kelley , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: Re: [PATCH] Revert "scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()" Message-ID: <20201211140137.taqjndaqjjo25srj@liuwe-devbox-debian-v2> References: <20201211131404.21359-1-parri.andrea@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201211131404.21359-1-parri.andrea@gmail.com> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 11, 2020 at 02:14:04PM +0100, Andrea Parri (Microsoft) wrote: > This reverts commit 3b8c72d076c42bf27284cda7b2b2b522810686f8. > > Dexuan reported a regression where StorVSC fails to probe a device (and > where, consequently, the VM may fail to boot). The root-cause analysis > led to a long-standing race condition that is exposed by the validation > /commit in question. Let's put the new validation aside until a proper > solution for that race condition is in place. > > Signed-off-by: Andrea Parri (Microsoft) > Cc: Dexuan Cui > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: linux-scsi@vger.kernel.org Hi Martin Sorry for the last minute patch. We would very like this goes into 5.10 if possible; otherwise Linux 5.10 is going to be broken on Hyper-V. :-( Wei.