Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qq/4De6eCPqwrVfx8GPQkXuCpgpSzD4tLD8havXGCnDnj7wMURw3K3f7DdV49vgx+NaOlFE5fp
 qIDKEyHzwWHA==
IronPort-SDR: ENbV8zVbC8ATmpe21dWVwIvKWHRJBscF/ML/5oqXEI44K2+fV5ZbuEzVPNkCnbxdh7SaJM4iNZ
 a2R3zwhMf6mw==
Date:   Fri, 11 Dec 2020 16:16:24 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Sam Protsenko <semen.protsenko@linaro.org>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH 2/2] usb: dwc3: drd: Avoid error when extcon is missing
Message-ID: <20201211141624.GQ4077@smile.fi.intel.com>
References: <20201210203318.6914-1-semen.protsenko@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201210203318.6914-1-semen.protsenko@linaro.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Dec 10, 2020 at 10:33:18PM +0200, Sam Protsenko wrote:
> If "port" node is missing in PHY controller node, dwc3_get_extcon()
> isn't able to find extcon device. This is perfectly fine in case when
> "usb-role-switch" or OTG is used, but next misleading error message is
> printed in that case, from of_graph_get_remote_node():
> 
>     OF: graph: no port node found in /phy@1234abcd
> 
> Avoid printing that message by checking if port node exists in PHY node
> before calling of_graph_get_remote_node().

By some reason you have two separate messages (missed --thread when run `git
format-patch ...`?).

In any case I think it should be dropped or reworked and resent since patch 1/2
got comments.

-- 
With Best Regards,
Andy Shevchenko