Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201210035540.32530-1-TheSven73@gmail.com> <5ff5fd64-2bf0-cbf7-642f-67be198cba05@gmail.com>
In-Reply-To: <5ff5fd64-2bf0-cbf7-642f-67be198cba05@gmail.com>
From:   Sven Van Asbroeck <thesven73@gmail.com>
Date:   Fri, 11 Dec 2020 07:43:40 -0500
Message-ID: <CAGngYiXsyRH=5UYwaCkVDDGkRX6m_Cw9iam+nSRZwA1=ZNPnOQ@mail.gmail.com>
Subject: Re: [PATCH net v2] lan743x: fix rx_napi_poll/interrupt ping-pong
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Bryan Whitehead <bryan.whitehead@microchip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        David S Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
        netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Heiner,

On Thu, Dec 10, 2020 at 2:32 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
>
> In addition you could play with sysfs attributes
> /sys/class/net/<if>/gro_flush_timeout
> /sys/class/net/<if>/napi_defer_hard_irqs

Interesting, I will look into that.

> > @@ -2407,7 +2409,7 @@ static int lan743x_rx_open(struct lan743x_rx *rx)
> >
> >       netif_napi_add(adapter->netdev,
> >                      &rx->napi, lan743x_rx_napi_poll,
> > -                    rx->ring_size - 1);
> > +                    64);
>
> This value isn't completely arbitrary.
> Better use constant NAPI_POLL_WEIGHT.
>

Thank you, I will change it in the next patch version.