Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Dec 2020 13:56:28 +0100
From:   Marek Behun <marek.behun@nic.cz>
To:     Abanoub Sameh <abanoubsameh8@gmail.com>
Cc:     pavel@ucw.cz, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Abanoub Sameh <abanoubsameh@protonmail.com>,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] leds: led-core: Get rid of enum led_brightness
Message-ID: <20201211135628.1fe1af79@nic.cz>
In-Reply-To: <20201211014840.1554095-1-abanoubsameh@protonmail.com>
References: <20201211014840.1554095-1-abanoubsameh@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 11 Dec 2020 03:48:40 +0200
Abanoub Sameh <abanoubsameh8@gmail.com> wrote:

> This gets rid of enum led_brightness in the main led files,
> because it is deprecated, and an int can be used instead,
> or maybe even a uint8_t since it only goes up to 255.
> Next we can also patch the other files to get rid of it completely.

1. unsigned int should be used IMO
  - using int may force all implementers to check for negative value
    and return -EINVAL, which is stupid
  - some LED controllers may offer more than 8bit brightness value, so
    no uint8_t
2. I think we should remove all usages with one commit

Marek