Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750798AbWIAUvg (ORCPT ); Fri, 1 Sep 2006 16:51:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750799AbWIAUvg (ORCPT ); Fri, 1 Sep 2006 16:51:36 -0400 Received: from sj-iport-1-in.cisco.com ([171.71.176.70]:13759 "EHLO sj-iport-1.cisco.com") by vger.kernel.org with ESMTP id S1750798AbWIAUvf (ORCPT ); Fri, 1 Sep 2006 16:51:35 -0400 To: Andrew Morton Cc: Adrian Bunk , Tom Tucker , Steve Wise , Roland Dreier , linux-kernel@vger.kernel.org, openib-general@openib.org, "David S. Miller" Subject: Re: 2.6.18-rc5-mm1: drivers/infiniband/hw/amso1100/c2.c compile error X-Message-Flag: Warning: May contain useful information References: <20060901015818.42767813.akpm@osdl.org> <20060901160023.GB18276@stusta.de> <20060901101340.962150cb.akpm@osdl.org> <20060901112312.5ff0dd8d.akpm@osdl.org> <20060901130444.48f19457.akpm@osdl.org> From: Roland Dreier Date: Fri, 01 Sep 2006 13:51:32 -0700 In-Reply-To: <20060901130444.48f19457.akpm@osdl.org> (Andrew Morton's message of "Fri, 1 Sep 2006 13:04:44 -0700") Message-ID: User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 01 Sep 2006 20:51:33.0437 (UTC) FILETIME=[6877A6D0:01C6CE08] Authentication-Results: sj-dkim-1.cisco.com; header.From=rdreier@cisco.com; dkim=pass ( sig from cisco.com verified; ); Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 634 Lines: 18 Andrew> No, driver-specific workarounds are not legitimate, sorry. Andrew> The driver should simply fail to compile on architectures Andrew> which do not implement __raw_writeq(). But how should i386 (say) implement __raw_writeq()? As two __raw_writel()s protected by a spinlock (that serializes all IO transactions)? That seems rather ugly. - R. -- VGER BF report: H 0 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/