Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Dec 2020 17:38:01 +0100
From:   =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= <mirq-linux@rere.qmqm.pl>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Dmitry Osipenko <digetx@gmail.com>,
        Johnny Chuang <johnny.chuang.emc@gmail.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v8 3/4] input: elants: read touchscreen size for
 EKTF3624
Message-ID: <20201211163801.GB23095@qmqm.qmqm.pl>
References: <cover.1607669375.git.mirq-linux@rere.qmqm.pl>
 <fa6a0e3f95803d6eab39cd0e3ba188842274a1e0.1607669375.git.mirq-linux@rere.qmqm.pl>
 <X9MeISZqBcvcnYXe@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <X9MeISZqBcvcnYXe@google.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Thu, Dec 10, 2020 at 11:22:09PM -0800, Dmitry Torokhov wrote:
> Hi Micha?,
> 
> On Fri, Dec 11, 2020 at 07:53:56AM +0100, Micha? Miros?aw wrote:
> > +
> > +	if (!phy_x || !phy_y) {
> > +		dev_warn(&client->dev,
> > +			 "invalid size data: %d x %d mm\n",
> > +			 phy_x, phy_y);
> > +		return 0;
> 
> Given we are not treating this as hard error mind dropping this "return"
> and making the below an "else" branch?

It is an error, still, and saves a bit of indentation in the following
normal-path code. But I see that there is already a similar code with
an 'else' branch.

Best Regards,
Micha? Miros?aw