Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp650783pxu; Fri, 11 Dec 2020 10:50:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJxos2JWMRcFCesjwnU7OaXQJA3EA8OMJcj7MDyKBpZB7iotU7Pscd67WQT/JoNehRGdc4ES X-Received: by 2002:a17:906:f1c8:: with SMTP id gx8mr12241449ejb.524.1607712626275; Fri, 11 Dec 2020 10:50:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607712626; cv=none; d=google.com; s=arc-20160816; b=XAIYGWEjwXestm1bt4nIWJ+MV1j1egtS6XWTHVG5wGaGe+42wG6GD69m1r5T17RmfS f2eTny6QMGNiSEiXjN5TQn0wc3wURQcD3RSYCicjYTesPr0ImCH/BQFgOBitlfVGZWY1 ZMtPdbcpaRI/NYEmXX/SCUmwH+9GAhD436AsN5Iq29vNgnhSGdK3ATP6pcTiTdCzsU9d 2jk0vwYEihROL84WK6wx2tMUV3LOkrxBqcxIKs7NmhlQ1eo8ru1vE5JEcUpf23YfmDF9 mTxaHBodQP7iAc42qOirFMfx+MqxxVRUuiQ2VTFHjIoNWSKStKTKi12isVWKizhjk/3Q BccA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=5NFjWtKxW0OIGHrg72oAUmrTJl8dba4j96C0Hoh9Chk=; b=Q76snnsBcg3dOJ2a+7D9XTiiZ7DYjOqpoGmQI+7ZVRSOoBreAy7/XC11S4DyaxfGz6 OqFRy+7ZtnbACCU0p4O6RutWPPHqN6Fd9u11V1mbf6navIz+jBg2M2sg2ho+9fcKbhCP 3z53t71Z4OMDuxQbSEWOTTkY6QqWbMHUoULaqg7DORQ5+8+SyzJRnGdcUshSx4v8i3vn 8/Oh8cQVGpZKmcesRkJuZAwsVgt9ni1o2ryBi863znE0aPMFB7Y4gRM5TdL0zHXcAMBk jn9U8Mz9SsBUXeaBrQ3lIzj+2hF3TjMacabB9CcWHuPHtndau0y/s1fU/DCNB3OQpqw6 wmFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m26si5720473edp.592.2020.12.11.10.50.03; Fri, 11 Dec 2020 10:50:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391845AbgLKQvn (ORCPT + 99 others); Fri, 11 Dec 2020 11:51:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:34800 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390078AbgLKQtc (ORCPT ); Fri, 11 Dec 2020 11:49:32 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 51965B19B; Fri, 11 Dec 2020 16:48:15 +0000 (UTC) From: Nicolas Saenz Julienne To: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org Cc: f.fainelli@gmail.com, linux-pwm@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, wahrenst@gmx.net, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, p.zabel@pengutronix.de, linux-gpio@vger.kernel.org, linus.walleij@linaro.org, linux-clk@vger.kernel.org, sboyd@kernel.org, linux-rpi-kernel@lists.infradead.org, bgolaszewski@baylibre.com, andy.shevchenko@gmail.com, Nicolas Saenz Julienne Subject: [PATCH v6 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind Date: Fri, 11 Dec 2020 17:47:55 +0100 Message-Id: <20201211164801.7838-7-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201211164801.7838-1-nsaenzjulienne@suse.de> References: <20201211164801.7838-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c index 5d1aacdd84ef..068715d6e66d 100644 --- a/drivers/soc/bcm/raspberrypi-power.c +++ b/drivers/soc/bcm/raspberrypi-power.c @@ -177,7 +177,7 @@ static int rpi_power_probe(struct platform_device *pdev) return -ENODEV; } - rpi_domains->fw = rpi_firmware_get(fw_np); + rpi_domains->fw = devm_rpi_firmware_get(&pdev->dev, fw_np); of_node_put(fw_np); if (!rpi_domains->fw) return -EPROBE_DEFER; -- 2.29.2