Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <c42cdf7d51ec880b4941a8e1b7ec855c9bc746e8.camel@perches.com>
Subject: Re: [PATCH -next] fs/xfs: convert comma to semicolon
From:   Joe Perches <joe@perches.com>
To:     David Laight <David.Laight@ACULAB.COM>,
        'Eric Sandeen' <sandeen@sandeen.net>,
        Zheng Yongjun <zhengyongjun3@huawei.com>,
        "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
        "darrick.wong@oracle.com" <darrick.wong@oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Fri, 11 Dec 2020 08:55:12 -0800
In-Reply-To: <5f4ee9cf48a445cea25ba01bc9ffdf13@AcuMS.aculab.com>
References: <20201211084112.1931-1-zhengyongjun3@huawei.com>
         <fd372b27-983d-00ff-5218-4082fe2f08df@sandeen.net>
         <5f4ee9cf48a445cea25ba01bc9ffdf13@AcuMS.aculab.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2020-12-11 at 16:17 +0000, David Laight wrote:
> From: Eric Sandeen
> > Sent: 11 December 2020 15:51
> > 
> > On 12/11/20 2:41 AM, Zheng Yongjun wrote:
> > > Replace a comma between expression statements by a semicolon.
> > > 
> > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> > 
> > hah, that's an old one.  Harmless though, AFAICT.
> > 
> > this fixes 91cca5df9bc8 ("[XFS] implement generic xfs_btree_delete/delrec")
> > if we dare add that tag ;)
> 
> It doesn't 'fix' anything, it is just stylistic.
> Completely harmless in every sense.

True, so it's not necessary to add a fixes tag here.

The only time a comma->semicolon conversion could 'fix'
something is when it's unintentionally used after something
like an if statement

	if (foo)
		bar(),
	baz();

where now baz() is performed only when the if condition is true
but the indentation indicates that it should always be performed.