Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp663213pxu; Fri, 11 Dec 2020 11:08:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJyPfN8FyLeQq9pmLbtBT4c5C5jsiq5AHW6PY/Vi7Kg9twbcWUz/2NIUeRwBeTFc+0g+2ONd X-Received: by 2002:a17:906:8354:: with SMTP id b20mr12273844ejy.397.1607713682690; Fri, 11 Dec 2020 11:08:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607713682; cv=none; d=google.com; s=arc-20160816; b=B2zowpK50IsG+TQD9CRtY/IqrH+ModZMhWG3lMws2BYQOFDHWDa/YnaYlHSp+0nOCY nPVZzXahy9FOapW6ZMWaYKoBhhBj7XzS+hrmSEGJx7KzJTZ99Xh3ulvQ21Rh4iC77dQF jcarURvto0xP0dDRYgTPOKN1B/6GwftBn9t7J/sGkJyM3x1SDbv1fe6lKsFD5fwZiEG8 cJQlNb7AYszZqgyNPt0SanwNz57Y8Ty5yCVjeG3jXZdEf+Q3IaBufQ0QZ+OnTP2achpR LoNkrFlcnfsl9hn8dLj0BcGimZ1QN1FWApt+lORO43HK8oK1qYku46m5b3ybaRRFFDXi Jl+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8YKH8lK0Ftp/s46PsvGESW0EJErn9Owh6lZRtwj0uaQ=; b=DgZsmAolP9lrHIWLgUaQ5lG1uKaE17vR6C8zYZiTl+mu+0FEjzMBkYGp4RqSgti3vz vPaGDBPouqgrK4cWr14Z7yPUFAmwsG9g1eTi6wh+rFTBcR0zldX6nrxXlZwyYUOxazL3 8wxUAPpJZ2TKiUOciUoChi+Cr0RJ8FhhhK3GRMQKvhlD3jy6H/jT901wnvaxxAGvflwC AH1L0fVArgzneoQd8aDOkf2ZSshJI2ml1oB3HSzjwqdBzNAzD8oA3yUeBU9P10ToWHf9 k62OTMWLEw9JVWUcfDbDWINObnIrop3LUxCdlh4crltm0YA/26fkNYIQh9p9fESmRDeO jiEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Jq7q0kGu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi25si5462706edb.487.2020.12.11.11.07.39; Fri, 11 Dec 2020 11:08:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Jq7q0kGu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730713AbgLKSTD (ORCPT + 99 others); Fri, 11 Dec 2020 13:19:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390274AbgLKSSk (ORCPT ); Fri, 11 Dec 2020 13:18:40 -0500 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6935C0617A6 for ; Fri, 11 Dec 2020 10:17:27 -0800 (PST) Received: by mail-pg1-x533.google.com with SMTP id x24so1827280pgf.0 for ; Fri, 11 Dec 2020 10:17:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8YKH8lK0Ftp/s46PsvGESW0EJErn9Owh6lZRtwj0uaQ=; b=Jq7q0kGut4O4GKUlDdKjcJvyGptTrQ/BtYXgc0fwG8rHhxqNtU/c9YDApmuhO3QSfR WHfDtHgrWJA/2LK/W5+1SPqz9VgqKZXqyVBE7mxgyaDIoZowR7IVt5vs+13X2HiFW0Pt 46+kDeB4eZ6Mpbe758NDr4pkMrGkLwdJdpfdo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8YKH8lK0Ftp/s46PsvGESW0EJErn9Owh6lZRtwj0uaQ=; b=G9y85xAZE2hlOn9KPP8U6aiWFxCfBp12v4jWKFgkUi71nnpT8AZ/rjz/zZF4sX2fc/ srXYDZT+HR+Jxlk2XHrKhMhFrynAyx3R4azRBCl1gSz0KW/TcYv5nRlIZjaM77ZM+q2U e+ux5qBO/LOaBHwZY3c0Tj6pntoBV49F8ZaKE8nYcKgYBIZp31Ni/ua8upJ5bdnURXzX ysl49SFwsz25xp0pnbOuDDHDRy9oCTPiU/whlCWcJt+nTmb3hFnXqMmtb55zTkdf6JsA MlCI6aydO5V1jPGyiIQ9OOJyP3XacpeT4s/dCekYbJlznI0cYMdG+Zb8rVv1TJopxFBz X7gw== X-Gm-Message-State: AOAM533whpEYAoicDyzd2vppdgR/IsHLi1FsbA0zxpuv2Ozl10th9n/k 8xazeH/FRluP4yuNAWTIoRi+WQ== X-Received: by 2002:a65:4809:: with SMTP id h9mr13060878pgs.194.1607710647306; Fri, 11 Dec 2020 10:17:27 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m14sm10573452pgu.0.2020.12.11.10.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 10:17:26 -0800 (PST) Date: Fri, 11 Dec 2020 10:17:25 -0800 From: Kees Cook To: Zou Wei Cc: akpm@linux-foundation.org, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] lib/ubsan.c: Mark type_check_kinds with static keyword Message-ID: <202012111017.E58CBF6@keescook> References: <1607602638-79584-1-git-send-email-zou_wei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1607602638-79584-1-git-send-email-zou_wei@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 10, 2020 at 08:17:18PM +0800, Zou Wei wrote: > Fix the following sparse warning: > > lib/ubsan.c:20:12: warning: symbol 'type_check_kinds' was not declared. Should it be static? > > Signed-off-by: Zou Wei Reviewed-by: Kees Cook -- Kees Cook