Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp836556pxu; Fri, 11 Dec 2020 16:02:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJy0V0e+FzM34q//bhw1ZWJdIcEPqgSuYlQpbVkpH9N9G9HPUjpqRpe1tExv2f44Cyx8VWGI X-Received: by 2002:a17:907:da7:: with SMTP id go39mr13779726ejc.58.1607731361541; Fri, 11 Dec 2020 16:02:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607731361; cv=none; d=google.com; s=arc-20160816; b=yaflMKBNQg+amce+JnWL314isbHF87OowpTLJig19q0edt8/WidX5zZW0FuA5ee6na UQJ8KFJJAGzxouWGDzW5xW/6I9cVBrxefs30ghH4yI1X+Khknap9LmyRufnDVJQfG2OD /X4Jq1nAga5lDwvXdKb3MqV2yorXf9evFNA5UgO4Ld0z7uFiV9QI6Fc3VlhJURFFrtby SHCsBToOV16MrqtZwJJlwieRCkU4v7b3MCZRnNbh4h42o+g8dX8cAWmQfSfaeZ7AS+53 wW7jsYZk5DsTpz/YeMDVagKR88DAT9VFSxzI0rfCxjhhwpVzs/gtpI/ENia3M5J9zeS7 U/aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=cnwa9KGDLM49dYEcuz54RyXGs8b2Jq3ypk9qiva6vT4=; b=cJzNn97MVqMcPuQa771/XCOxNqe1QPB29K3FePlyezdiof1oa5wErIv/VzbqTa0plQ RSNl3eWStfhSYqEas6BKTevxWTOm66hCPAwpW/xMA0ZhPtfPP+YKehMPXySVezySz81z kjt6GfajOWd0yqmsY/4JLFCZpWmjbbg0qJBZdmcTYczjjnVWRL8DKDF2NsinPx4b5HVy F6QsI+orFJxYy163GX1A1CXhpAWDlf2AXYIMcrldRp3/9saczOsrNl0V7NyKBVMn6Fha MWkk9TU+ZCci53Y7009ZhSUwesIhn4Kv3l63F4wp6rnLaK6+kHfCLQx0enesHx1/a2RJ bOyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i1si5337610ejz.363.2020.12.11.16.02.19; Fri, 11 Dec 2020 16:02:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394902AbgLKBXL (ORCPT + 99 others); Thu, 10 Dec 2020 20:23:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:37260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394744AbgLKBVf (ORCPT ); Thu, 10 Dec 2020 20:21:35 -0500 From: paulmck@kernel.org Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, mingo@kernel.org, jiangshanlai@gmail.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, iamjoonsoo.kim@lge.com, andrii@kernel.org, "Paul E. McKenney" , Ming Lei , Jens Axboe Subject: [PATCH v3 sl-b 6/6] percpu_ref: Dump mem_dump_obj() info upon reference-count underflow Date: Thu, 10 Dec 2020 17:20:03 -0800 Message-Id: <20201211012003.16473-6-paulmck@kernel.org> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20201211011907.GA16110@paulmck-ThinkPad-P72> References: <20201211011907.GA16110@paulmck-ThinkPad-P72> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Paul E. McKenney" Reference-count underflow for percpu_ref is detected in the RCU callback percpu_ref_switch_to_atomic_rcu(), and the resulting warning does not print anything allowing easy identification of which percpu_ref use case is underflowing. This is of course not normally a problem when developing a new percpu_ref use case because it is most likely that the problem resides in this new use case. However, when deploying a new kernel to a large set of servers, the underflow might well be a new corner case in any of the old percpu_ref use cases. This commit therefore calls mem_dump_obj() to dump out any additional available information on the underflowing percpu_ref instance. Cc: Ming Lei Cc: Jens Axboe Cc: Joonsoo Kim Reported-by: Andrii Nakryiko Signed-off-by: Paul E. McKenney --- lib/percpu-refcount.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/percpu-refcount.c b/lib/percpu-refcount.c index e59eda0..a1071cd 100644 --- a/lib/percpu-refcount.c +++ b/lib/percpu-refcount.c @@ -5,6 +5,7 @@ #include #include #include +#include #include /* @@ -168,6 +169,7 @@ static void percpu_ref_switch_to_atomic_rcu(struct rcu_head *rcu) struct percpu_ref_data, rcu); struct percpu_ref *ref = data->ref; unsigned long __percpu *percpu_count = percpu_count_ptr(ref); + static atomic_t underflows; unsigned long count = 0; int cpu; @@ -191,9 +193,13 @@ static void percpu_ref_switch_to_atomic_rcu(struct rcu_head *rcu) */ atomic_long_add((long)count - PERCPU_COUNT_BIAS, &data->count); - WARN_ONCE(atomic_long_read(&data->count) <= 0, - "percpu ref (%ps) <= 0 (%ld) after switching to atomic", - data->release, atomic_long_read(&data->count)); + if (WARN_ONCE(atomic_long_read(&data->count) <= 0, + "percpu ref (%ps) <= 0 (%ld) after switching to atomic", + data->release, atomic_long_read(&data->count)) && + atomic_inc_return(&underflows) < 4) { + pr_err("%s(): percpu_ref underflow", __func__); + mem_dump_obj(data); + } /* @ref is viewed as dead on all CPUs, send out switch confirmation */ percpu_ref_call_confirm_rcu(rcu); -- 2.9.5