Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp836975pxu; Fri, 11 Dec 2020 16:03:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJzBa0U7h5IGQaGLYzRA97e0zWhXvfLErxtpiT4cnu9Ii/9Z+kfpxykRzZk8jK/cohxQ+ABq X-Received: by 2002:a50:e0ce:: with SMTP id j14mr14544485edl.18.1607731396832; Fri, 11 Dec 2020 16:03:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607731396; cv=none; d=google.com; s=arc-20160816; b=tmmkg4/FybsVTkKNrJS7eFoXsSQ7JXkIiDNpYeFmX/XQYK0pkIZzN4JljY4f/XBAYg lKCCAqamxlQXG9V0pb3JyMWnOfBoP82jR/YTy6Ji7ee9HQhYb6FZD976fXHRcdubZDTN 26v68YtG3UukF8cMWbDpAmy0Issp5Lbu6iNPl8d2VDRfrcuFD4uHPWY5Ir3Zzk4baEIy p/bDW/ev3PPqpWkEOWzFMmXgnb7NmlJFuK2vh+Yt9bMOk7wdYrIWMBWQVV0V5wJv8W68 YBI58Km6XEZuIykCC2TBoIcyDHlXdv7ZpSnPHxdNwie+oVn2GXgooMSuxeU9p0ex8QNx 4ArQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-filter; bh=yGgzoIdOorbDs7MxKlg+eL3hr036hpEtLmS92RUcudE=; b=NSU0yXTD5C/ceei7RfzILQUX7AQLQJacLWi4raLYVyQwO+mCogwoVgoeMhkr+tdxoJ YluqR3JFLXHrIprCb1TdesgBxe5jMQa0MgMlhGMedcLtq5ISWGg3Tb8kCOA5rra8mU1w 63DIreNyzeKf9CqtRBJdIgZBaxtt0sl10aMYVR82LBuooeJHbAQisEONz9X3/+CNIs35 6W5v/vrHcnbgXQnecpihWuO8lzsDfGshDmKRwoecmEi7/820agrSb8itqlhBS3bNl6AN yn7nsGCasoTkKgT97iwgl3gDzkRCoFSl1VbIemfJP3WaeHOCoA4VW5m98c/eOY2T6z+w 8kCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=atAYxjfS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t6si5705759edq.353.2020.12.11.16.02.54; Fri, 11 Dec 2020 16:03:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=atAYxjfS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387992AbgLKBad (ORCPT + 99 others); Thu, 10 Dec 2020 20:30:33 -0500 Received: from linux.microsoft.com ([13.77.154.182]:53436 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389797AbgLKBa3 (ORCPT ); Thu, 10 Dec 2020 20:30:29 -0500 Received: from [192.168.86.31] (c-71-197-163-6.hsd1.wa.comcast.net [71.197.163.6]) by linux.microsoft.com (Postfix) with ESMTPSA id 5007320B717A; Thu, 10 Dec 2020 17:29:48 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5007320B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1607650188; bh=yGgzoIdOorbDs7MxKlg+eL3hr036hpEtLmS92RUcudE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=atAYxjfS4S+6flO2iq7tGQCKH1dwb7TX5DHXLt0M7SEA+Olvn4o6HH1g3u6UypVYd E7ApJD01S/8ifxPosxr9WzFOQW8E7wJUsOfc3rtrgqzjLTSO5++WuHAk1H8xmfc3qF Ph8i/xozYVTLTThJbGWxwTrie4zn0apcGL67klHQ= Subject: Re: [PATCH v7 6/8] IMA: extend critical data hook to limit the measurement based on a label To: Tyler Hicks Cc: zohar@linux.ibm.com, stephen.smalley.work@gmail.com, casey@schaufler-ca.com, agk@redhat.com, snitzer@redhat.com, gmazyland@gmail.com, paul@paul-moore.com, sashal@kernel.org, jmorris@namei.org, nramas@linux.microsoft.com, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com References: <20201209194212.5131-1-tusharsu@linux.microsoft.com> <20201209194212.5131-7-tusharsu@linux.microsoft.com> <20201210231922.GK489768@sequoia> From: Tushar Sugandhi Message-ID: Date: Thu, 10 Dec 2020 17:29:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201210231922.GK489768@sequoia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-12-10 3:19 p.m., Tyler Hicks wrote: > On 2020-12-09 11:42:10, Tushar Sugandhi wrote: >> The IMA hook ima_measure_critical_data() does not support a way to >> specify the source of the critical data provider. Thus, the data >> measurement cannot be constrained based on the data source label >> in the IMA policy. >> >> Extend the IMA hook ima_measure_critical_data() to support passing >> the data source label as an input parameter, so that the policy rule can >> be used to limit the measurements based on the label. >> >> Signed-off-by: Tushar Sugandhi > > Reviewed-by: Tyler Hicks > > Tyler > Thanks for the review. ~Tushar