Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750777AbWIBBdi (ORCPT ); Fri, 1 Sep 2006 21:33:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750780AbWIBBdi (ORCPT ); Fri, 1 Sep 2006 21:33:38 -0400 Received: from gateway.insightbb.com ([74.128.0.19]:56870 "EHLO asav00.insightbb.com") by vger.kernel.org with ESMTP id S1750777AbWIBBdi (ORCPT ); Fri, 1 Sep 2006 21:33:38 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aa4HAKh8+ESBT4lWLA From: Dmitry Torokhov To: Grant Coady Subject: Re: 2.6.18-rc5-mm1 Date: Fri, 1 Sep 2006 21:33:35 -0400 User-Agent: KMail/1.9.3 Cc: Andrew Morton , linux-kernel@vger.kernel.org References: <20060901015818.42767813.akpm@osdl.org> <3tkhf2p4f1n1s7ancfmclrlijvne8nhoit@4ax.com> <200609012112.18826.dtor@insightbb.com> In-Reply-To: <200609012112.18826.dtor@insightbb.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200609012133.35901.dtor@insightbb.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1881 Lines: 65 On Friday 01 September 2006 21:12, Dmitry Torokhov wrote: > On Friday 01 September 2006 21:06, Grant Coady wrote: > > On Fri, 1 Sep 2006 01:58:18 -0700, Andrew Morton wrote: > > > > > > > >ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc5/2.6.18-rc5-mm1/ > > ... > > >- See the `hot-fixes' directory for any important updates to this patchset. > > > > > Okay, I applied hotfixes and it crashed on boot, keyboard LEDs flashing: > > > > Repeating message, hand copied: > > atkbd.c: Spurious ACK in isa0060/serio0. Some program might be trying access > > hardware directly. > > > > Please try booting with i8042.panicblink=0 to see the real oops (important > data). .. or try the patch below. -- Dmitry Input: i8042 - disable keyboard port when panicking and blinking This should get rid of "spurious ACK" messages from atkbd driver during panic. Signed-off-by: Dmitry Torokhov --- drivers/input/serio/i8042.c | 7 +++++++ 1 files changed, 7 insertions(+) Index: work/drivers/input/serio/i8042.c =================================================================== --- work.orig/drivers/input/serio/i8042.c +++ work/drivers/input/serio/i8042.c @@ -836,9 +836,16 @@ static long i8042_panic_blink(long count */ if (!i8042_blink_frequency) return 0; + if (count - last_blink < i8042_blink_frequency) return 0; + /* + * Disable keyboard port so ATKBD won't fill logs with + * "spurious ACK" messages + */ + i8042_ports[I8042_KBD_PORT_NO].exists = 0; + led ^= 0x01 | 0x04; while (i8042_read_status() & I8042_STR_IBF) DELAY; -- VGER BF report: H 0 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/