Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1209019pxu; Sat, 12 Dec 2020 05:36:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1CtQlhbA83DB0p9mA9uRwc5VPXQV0n6SEU9rhmFPkiu+Rnuzc1THRa6Wm/ddxrZttDNVv X-Received: by 2002:a50:8d89:: with SMTP id r9mr15939673edh.144.1607780193543; Sat, 12 Dec 2020 05:36:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607780193; cv=none; d=google.com; s=arc-20160816; b=elvZJCi+sDC1hMep2a4fTcn2HQq2AimnexEPWj9aTTbiyiZUoSGb1Fr8IFJFN/Sfe5 6BgfMFvwUtmgghX4VAsWj7t8tUERpRhMRUjbjxbnbiM0b6N0+DyBtyybJK0OilvIhsB/ q4pNDFfff//GAE9aYhe4QLaWma3G+Wx/1xOW3mOfwT2LJpgm3KQyOIXVUgMiz19xJAKK lnf9Xxa0F5/XhfdaAuKYOGHfIUut7h7yKdxD7ZNnFBWefxFkWyE+WVwvd9wf7qvcGBYm btrnUfBwnIpmp1R4LY21wMkP4wGMKpi7IQXxd3qQ7J4Bfr+6JcJlDWb4+PkSzxO1RVw2 MPZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mkYYI/QaMIASMoGa2tPorA5qc4IZLLQfZJ6OGgZdQgU=; b=xfnFA2UUOxmvxDp9EVcRS/ed9MbIkTjCcnsGgsCdMP84+mRFp6ltGfc2+6VHDYXFN2 2DibzcGBfEhYYA47+TgTSaJxwz6XD3ksLjfd2/TpiJ4Qvqo/B08czxoGerWO3UggyuqK u9gdagp2L1IzaN5UQxzNK7bO2G24+EwJ3FGoGPUqIFY1kwYITNjS611fn/98s1mMEfvH 8p1hxwZBU44nQIgmF2+6JKtirp8/nYge61ptkVvIrpxGpFCu+TC513ODZytsYP7xjiKA ZIFeZaG6DanbLXpanF0KTwDKZq3/+s0HVOKgmA8e0emmQ//DDFcoQS6PewCpUO9rAkZA fQgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jg19si6162144ejc.365.2020.12.12.05.36.10; Sat, 12 Dec 2020 05:36:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437613AbgLKPDq (ORCPT + 99 others); Fri, 11 Dec 2020 10:03:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:33308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437556AbgLKPDL (ORCPT ); Fri, 11 Dec 2020 10:03:11 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C97DD22B2E; Fri, 11 Dec 2020 15:01:56 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1knjvf-000TxV-1q; Fri, 11 Dec 2020 15:01:55 +0000 From: Marc Zyngier To: shawnguo@kernel.org, linux@rasmusvillemoes.dk, leoyang.li@nxp.com, mark.rutland@arm.com, zhiqiang.hou@nxp.com, Biwen Li , robh+dt@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, Marc Zyngier Cc: xiaobo.xie@nxp.com, Hou Zhiqiang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Biwen Li , jiafei.pan@nxp.com, Tsahee Zidenberg , Antoine Tenart Subject: Re: [PATCH] irqchip/alpine-msi: Fix freeing of interrupts on allocation error path Date: Fri, 11 Dec 2020 15:01:40 +0000 Message-Id: <160769813659.482133.9468394664184226982.b4-ty@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201129135525.396671-1-maz@kernel.org> References: <20201129135525.396671-1-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: shawnguo@kernel.org, linux@rasmusvillemoes.dk, leoyang.li@nxp.com, mark.rutland@arm.com, zhiqiang.hou@nxp.com, biwen.li@oss.nxp.com, robh+dt@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, maz@kernel.org, xiaobo.xie@nxp.com, Zhiqiang.Hou@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, biwen.li@nxp.com, jiafei.pan@nxp.com, tsahee@annapurnalabs.com, atenart@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Nov 2020 13:55:25 +0000, Marc Zyngier wrote: > The alpine-msi driver has an interesting allocation error handling, > where it frees the same interrupts repeatedly. Hilarity follows. > > This code is probably never executed, but let's fix it nonetheless. Applied to irq/irqchip-next, thanks! [1/1] irqchip/alpine-msi: Fix freeing of interrupts on allocation error path commit: 3841245e8498a789c65dedd7ffa8fb2fee2c0684 Cheers, M. -- Without deviation from the norm, progress is not possible.