Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750733AbWIBDNj (ORCPT ); Fri, 1 Sep 2006 23:13:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750753AbWIBDNj (ORCPT ); Fri, 1 Sep 2006 23:13:39 -0400 Received: from smtp.osdl.org ([65.172.181.4]:50122 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750733AbWIBDNj (ORCPT ); Fri, 1 Sep 2006 23:13:39 -0400 Date: Fri, 1 Sep 2006 20:13:05 -0700 From: Andrew Morton To: tglx@linutronix.de Cc: Ingo Molnar , LKML , Frank v Waveren Subject: Re: [PATCH] prevent timespec/timeval to ktime_t overflow Message-Id: <20060901201305.f01ec7d2.akpm@osdl.org> In-Reply-To: <1157103042.29250.337.camel@localhost.localdomain> References: <1156927468.29250.113.camel@localhost.localdomain> <20060831204612.73ed7f33.akpm@osdl.org> <1157100979.29250.319.camel@localhost.localdomain> <20060901020404.c8038837.akpm@osdl.org> <1157103042.29250.337.camel@localhost.localdomain> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2847 Lines: 77 On Fri, 01 Sep 2006 11:30:42 +0200 Thomas Gleixner wrote: > > > > With that patch the machine emits 88 bigabytes of stuff then locks up. > > Something a little less aggressive is needed, methinks. > > Fun, here is a version with a bigabyte blocker. Your patch triggers waaaaaaay early. netconsole: remote IP 192.168.2.33 netconsole: remote ethernet address 00:0d:56:c6:c6:cc Initializing CPU#0 PID hash table entries: 4096 (order: 12, 32768 bytes) time.c: Using 14.318180 MHz WALL HPET GTOD HPET/TSC timer. time.c: Detected 3400.238 MHz processor. ktime_set: -1157140842 : 0 BUG: warning at include/linux/ktime.h:84/ktime_set() Call Trace: [] hrtimer_run_queues+0x10e/0x211 [] run_timer_softirq+0x28/0x1dc [] __do_softirq+0x58/0xcf [] call_softirq+0x1c/0x28 [] do_softirq+0x31/0x84 [] irq_exit+0x3f/0x4b [] do_IRQ+0x62/0x6c [] ret_from_intr+0x0/0xa [] console_init+0x0/0x37 [] start_kernel+0x123/0x1d0 [] _sinittext+0x27a/0x281 Console: colour VGA+ 80x25 Dentry cache hash table entries: 524288 (order: 10, 4194304 bytes) So I modified it to only trigger if current->mm!=NULL and: EXT3-fs: recovery complete. EXT3-fs: mounted filesystem with ordered data mode. VFS: Mounted root (ext3 filesystem) readonly. Freeing unused kernel memory: 156k freed ktime_set: -1157141318 : 0 BUG: warning at kernel/hrtimer.c:892/ktime_set() Call Trace: [] ktime_set+0x73/0x8b [] hrtimer_run_queues+0x55/0x140 [] run_timer_softirq+0x28/0x1dc [] __do_softirq+0x58/0xcf [] call_softirq+0x1c/0x28 [] do_softirq+0x31/0x84 [] irq_exit+0x3f/0x4b [] smp_apic_timer_interrupt+0x42/0x46 [] apic_timer_interrupt+0x66/0x6c [] __handle_mm_fault+0x42a/0x990 [] __handle_mm_fault+0x409/0x990 [] _spin_unlock_irqrestore+0x1a/0x38 [] do_page_fault+0x3b6/0x75c [] free_hot_cold_page+0x12c/0x14f [] free_hot_page+0xb/0xd [] __free_pages+0x29/0x32 [] free_pages+0x80/0x82 [] error_exit+0x0/0x84 I wonder if this is related to the occasional hrtimr_run_queues() lockup which Andi is encountering. -- VGER BF report: H 9.0096e-09 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/