Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1402431pxu; Sat, 12 Dec 2020 11:34:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJyrq8uod/Wl20/1zMFyZjxqrwllqIGQctmL36OCjxt4SLxknV5pTUKC6f3EcVoRhlny0cSx X-Received: by 2002:a17:907:9627:: with SMTP id gb39mr16356346ejc.267.1607801661548; Sat, 12 Dec 2020 11:34:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607801661; cv=none; d=google.com; s=arc-20160816; b=Pm7tW9NZE2d5xLm/UGBH1uggxPZPeSD4UufBTKPdqyDHfuXmyFcWAkpti6CAxUXMlc knDxod8gZbkxASEvnFhTQ/04aLf3Bnjsx/FLMoOxmksCo6jCqjKQWDmsis3PLeKAstx+ Ln0o0m66s3JFcKHuQ2mI+gjNxW4XB55Izu2SIYDgeIoDqwJYUA7OwXRu1wmPhjMVcAQ+ 0oV2uETLKIdtPYRt3I2SbElgZFg6juPc5GtST6wsqPfe1Xxn/CA0DX7COBByfUd/hjA8 Sb68yGGzlolSJqXGmMSNyAdKs+EYh9V0R6YDr2sImYzJjNPbIqQYWYUSkyvkLFZGv4hn BI+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-filter; bh=ghhwTCKzUyzBuV9Ol4jB1Kk7JTxsBVEU1FEuL6OBZqI=; b=fLO8h2pgsSN2s9zptfa6xyxn8Z71Rbo3PUTxkhlM+sUMKrTfy419cAeYScl15FdqZN 5XCCDsXrGOcVbekCAXdvZ8sfahy3XlxC4AZyr196wdvZd6MOVaStcoTDvWDUZQvHNWWh 9YI8wp/8th28UAj2fOPdUPCDlSsEZKgWuebpPGEwg3Kn6+lY03cqAQ1OvUCQtcWZaXww 8hNkUhWzT+8uoPHPPBXQwMGiyBi1MVNVTMrWMBAzmw5eon+IMWXlf+AjeDptBGkZaEIw 1dDakzy/owDX57xNq3+joID1gSqV0cMZSbimGuzyvFpZRTPYQQ7E1CVtBQgP1Moku6by SIBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=bYm81nVR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k2si7243280edf.160.2020.12.12.11.33.58; Sat, 12 Dec 2020 11:34:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=bYm81nVR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395145AbgLKQ25 (ORCPT + 99 others); Fri, 11 Dec 2020 11:28:57 -0500 Received: from linux.microsoft.com ([13.77.154.182]:54224 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395153AbgLKQ2Z (ORCPT ); Fri, 11 Dec 2020 11:28:25 -0500 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id 8FDB120B717A; Fri, 11 Dec 2020 08:27:44 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8FDB120B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1607704064; bh=ghhwTCKzUyzBuV9Ol4jB1Kk7JTxsBVEU1FEuL6OBZqI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=bYm81nVRNFLJCOUD3nU2g3EPeAwM7yK2qWOhvVWpORfguzdsiC4R3aaW0/IYpeuLl wu0uusHuI0oKHKL3WrIzKUh8odyaPRYdyEa8h0YXJQKLWZLGcUjVZ/HMLQzaz9thKz 5n7nt+mo2Zp7g6IdTXi9xaHoI3yYbrY8HxyY/r0Y= Subject: Re: [PATCH v7 8/8] selinux: include a consumer of the new IMA critical data hook To: Tyler Hicks , Tushar Sugandhi Cc: zohar@linux.ibm.com, stephen.smalley.work@gmail.com, casey@schaufler-ca.com, agk@redhat.com, snitzer@redhat.com, gmazyland@gmail.com, paul@paul-moore.com, sashal@kernel.org, jmorris@namei.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com References: <20201209194212.5131-1-tusharsu@linux.microsoft.com> <20201209194212.5131-9-tusharsu@linux.microsoft.com> <20201211153618.GA4951@sequoia> <20201211154156.GB4951@sequoia> From: Lakshmi Ramasubramanian Message-ID: <27bce16a-9e95-2559-af37-b47b81bdcd2e@linux.microsoft.com> Date: Fri, 11 Dec 2020 08:27:44 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201211154156.GB4951@sequoia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/20 7:41 AM, Tyler Hicks wrote: > On 2020-12-11 09:36:30, Tyler Hicks wrote: >> The calls to pr_err() in this aren't quite following the style of the >> other error SELinux error messages. > > Sorry, I left out a word. I meant to say that the calls to pr_err() in > this *file* aren't quite following the right style. Please adjust all of > them. > > Thanks! > Thanks for reviewing the patch Tyler. I'll make the changes per your comments. -lakshmi