Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Dec 2020 17:13:05 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Ricardo Ribalda <ribalda@chromium.org>
Cc:     Cezary Rojewski <cezary.rojewski@intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Jie Yang <yang.jie@linux.intel.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Mateusz Gorski <mateusz.gorski@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: Intel: Skylake: skl-topology: Fix OOPs ib
 skl_tplg_complete
Message-ID: <20201211171305.GG4929@sirena.org.uk>
References: <20201211170629.871085-1-ribalda@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="df+09Je9rNq3P+GE"
Content-Disposition: inline
In-Reply-To: <20201211170629.871085-1-ribalda@chromium.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--df+09Je9rNq3P+GE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Dec 11, 2020 at 06:06:29PM +0100, Ricardo Ribalda wrote:

> If dobj->control is not initialized we end up in an OOPs during
> skl_tplg_complete:

>  		for (i = 0; i < se->items; i++) {
> -			struct snd_ctl_elem_value val;
> +			struct snd_ctl_elem_value val = {};

This bit looks like a separate fix?

--df+09Je9rNq3P+GE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/TqKAACgkQJNaLcl1U
h9BQeAf+OFcaJQh4d/Gjojcw4mPYxpP3Kwf7I4v7LvLnqMTDdaE1mdliR1JM+2YF
P+dKGxT1sP9q8FpsjAIDl20dRdGHa/yMdJcIGs8CZj9uEBxMuUu2OZVlHnTZ5kzS
tNxszxGAuQop+kJRlENIQ19TsOGpmgMYlllysVFyHGg6ZYi/yQA9ugqqjwoMlSg6
9A9leB+N1XfdvD6SqOFx904JpWoAh2XgD9W4CbjogSSg+lqroPBl2cQGaOkvhzOY
/jiYg7pVDqss0Hw6PHHLLBUqnzdfrd+G8XerW9ZK8PXcAroXfBYA9KlV+4UT14Fo
MPH2vmMrMbj488G0uYfsB3RYMQA5iw==
=DfZj
-----END PGP SIGNATURE-----

--df+09Je9rNq3P+GE--