Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] platform: surface: fix non-PM_SLEEP build warnings
To:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc:     Hans de Goede <hdegoede@redhat.com>,
        platform-driver-x86@vger.kernel.org
References: <20201211190335.16501-1-rdunlap@infradead.org>
From:   Maximilian Luz <luzmaximilian@gmail.com>
Message-ID: <3705938f-6f82-88ef-455b-e0f7459989e3@gmail.com>
Date:   Fri, 11 Dec 2020 21:23:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.3
MIME-Version: 1.0
In-Reply-To: <20201211190335.16501-1-rdunlap@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/11/20 8:03 PM, Randy Dunlap wrote:
> Fix build warnings when CONFIG_PM_SLEEP is not enabled and these
> functions are not used:
> 
> ../drivers/platform/surface/surface_gpe.c:189:12: warning: ‘surface_gpe_resume’ defined but not used [-Wunused-function]
>   static int surface_gpe_resume(struct device *dev)
>              ^~~~~~~~~~~~~~~~~~
> ../drivers/platform/surface/surface_gpe.c:184:12: warning: ‘surface_gpe_suspend’ defined but not used [-Wunused-function]
>   static int surface_gpe_suspend(struct device *dev)
>              ^~~~~~~~~~~~~~~~~~~
> 
> Fixes: 274335f1c557 ("platform/surface: Add Driver to set up lid GPEs on MS Surface device")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Maximilian Luz <luzmaximilian@gmail.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: platform-driver-x86@vger.kernel.org
> ---
>   drivers/platform/surface/surface_gpe.c |    2 ++
>   1 file changed, 2 insertions(+)
> 
> --- linux-next-20201210.orig/drivers/platform/surface/surface_gpe.c
> +++ linux-next-20201210/drivers/platform/surface/surface_gpe.c
> @@ -181,6 +181,7 @@ static int surface_lid_enable_wakeup(str
>   	return 0;
>   }
>   
> +#ifdef CONFIG_PM_SLEEP
>   static int surface_gpe_suspend(struct device *dev)
>   {
>   	return surface_lid_enable_wakeup(dev, true);
> @@ -190,6 +191,7 @@ static int surface_gpe_resume(struct dev
>   {
>   	return surface_lid_enable_wakeup(dev, false);
>   }
> +#endif
>   
>   static SIMPLE_DEV_PM_OPS(surface_gpe_pm, surface_gpe_suspend, surface_gpe_resume);
>   
> 

Right, thanks.

I assume this covers all instances of this warning in platform/surface?
Otherwise, a "platform: surface: gpe: ..." subject would make more sense.

As for the rest:

Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>

Regards,
Max