Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: CbR0Be67DWTqZciaZwLbPmd9C7A7L67LWwkMxnOL6akGezHCJKPu630plRwOXc4dF4S3P4bNMk
 AGWeYtMkqGx91ZWUfF912r/aUx1MOJP8++t99rYvDcOfD6b8kUauBOX4vMZq84q+CpcgMoUMFB
 SuNFs/sVCk3zh2qYsrD1xSMJ270U7Y0NNsqg+MlEC1E/xApjoS8nrgNou6do+dIooBJwt0dMia
 apUDG+El+mQm+ztbNUYGUnGYpOPAkFIxDQMeugqbSbzZLexndqeMYW3lbnzErRohY5EJ1c+XQV
 obg=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Puranjay Mohan <puranjay12@gmail.com>,
        "bjorn@helgaas.com" <bjorn@helgaas.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: block: skd: remove skd_pci_info()
Thread-Topic: [PATCH] drivers: block: skd: remove skd_pci_info()
Thread-Index: AQHWz9z+X41O+6EQc0KJnRIciprIXQ==
Date:   Fri, 11 Dec 2020 21:50:52 +0000
Message-ID: <BYAPR04MB496513CB49E42A3467427BF686CA0@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <20201211164137.8605-1-puranjay12@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: cc9a3a23-85fb-4267-8300-08d89e1ed4eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2020 21:50:52.9917
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MzIK5DtNcmB7cSG0nkRJ32jg36nVt3UBe4J9/kiea4YPdqpe3gZ+UkC3Mwbv6U31W7N7BTdrIvuiJQI3/kEY5EaDV6xPkJSn89R5FWVNRdw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB3958
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/11/20 08:45, Puranjay Mohan wrote:=0A=
> PCI core calls __pcie_print_link_status() for every device, it prints=0A=
> both the link width and the link speed. skd_pci_info() does the same=0A=
> thing again, hence it can be removed.=0A=
>=0A=
> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>=0A=
> ---=0A=
>  drivers/block/skd_main.c | 31 -------------------------------=0A=
>  1 file changed, 31 deletions(-)=0A=
>=0A=
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c=0A=
> index a962b4551bed..da7aac5335d9 100644=0A=
> --- a/drivers/block/skd_main.c=0A=
> +++ b/drivers/block/skd_main.c=0A=
> @@ -3134,40 +3134,11 @@ static const struct pci_device_id skd_pci_tbl[] =
=3D {=0A=
>  =0A=
>  MODULE_DEVICE_TABLE(pci, skd_pci_tbl);=0A=
>  =0A=
> -static char *skd_pci_info(struct skd_device *skdev, char *str)=0A=
> -{=0A=
> -	int pcie_reg;=0A=
> -=0A=
> -	strcpy(str, "PCIe (");=0A=
> -	pcie_reg =3D pci_find_capability(skdev->pdev, PCI_CAP_ID_EXP);=0A=
> -=0A=
> -	if (pcie_reg) {=0A=
> -=0A=
> -		char lwstr[6];=0A=
> -		uint16_t pcie_lstat, lspeed, lwidth;=0A=
> -=0A=
> -		pcie_reg +=3D 0x12;=0A=
> -		pci_read_config_word(skdev->pdev, pcie_reg, &pcie_lstat);=0A=
> -		lspeed =3D pcie_lstat & (0xF);=0A=
> -		lwidth =3D (pcie_lstat & 0x3F0) >> 4;=0A=
> -=0A=
> -		if (lspeed =3D=3D 1)=0A=
> -			strcat(str, "2.5GT/s ");=0A=
> -		else if (lspeed =3D=3D 2)=0A=
> -			strcat(str, "5.0GT/s ");=0A=
> -		else=0A=
> -			strcat(str, "<unknown> ");=0A=
The skd driver prints unknown if the speed is not "2.5GT/s" or "5.0GT/s".=
=0A=
__pcie_print_link_status()  prints "unknown" only if speed=0A=
value >=3D ARRAY_SIZE(speed_strings).=0A=
=0A=
If a buggy skd card returns value that is not !=3D ("2.5GT/s" or "5.0GT/s")=
=0A=
&& value < ARRAY_SIZE(speed_strings) then it will not print the unknown but=
=0A=
the value from speed string array.=0A=
=0A=
Which breaks the current behavior. Please correct me if I'm wrong.=0A=
> -		snprintf(lwstr, sizeof(lwstr), "%dX)", lwidth);=0A=
> -		strcat(str, lwstr);=0A=
> -	}=0A=
> -	return str;=0A=
> -}=0A=
>  =0A=
>  static int skd_pci_probe(struct pci_dev *pdev, const struct pci_device_i=
d *ent)=0A=
>  {=0A=
>  	int i;=0A=
>  	int rc =3D 0;=0A=
> -	char pci_str[32];=0A=
>  	struct skd_device *skdev;=0A=
>  =0A=
>  	dev_dbg(&pdev->dev, "vendor=3D%04X device=3D%04x\n", pdev->vendor,=0A=
> @@ -3201,8 +3172,6 @@ static int skd_pci_probe(struct pci_dev *pdev, cons=
t struct pci_device_id *ent)=0A=
>  		goto err_out_regions;=0A=
>  	}=0A=
>  =0A=
> -	skd_pci_info(skdev, pci_str);=0A=
> -	dev_info(&pdev->dev, "%s 64bit\n", pci_str);=0A=
>  =0A=
>  	pci_set_master(pdev);=0A=
>  	rc =3D pci_enable_pcie_error_reporting(pdev);=0A=
=0A=