Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Dec 2020 23:38:22 +0100
From:   Pavel Machek <pavel@denx.de>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Pavel Machek <pavel@denx.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 4.19 15/39] ALSA: hda/generic: Add option to enforce
 preferred_dacs pairs
Message-ID: <20201211223822.GB18452@amd>
References: <20201210142602.272595094@linuxfoundation.org>
 <20201210142603.037114540@linuxfoundation.org>
 <20201211083621.GA9395@duo.ucw.cz>
 <s5hy2i4pwdk.wl-tiwai@suse.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="tjCHc7DPkfUGtrlw"
Content-Disposition: inline
In-Reply-To: <s5hy2i4pwdk.wl-tiwai@suse.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk


--tjCHc7DPkfUGtrlw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> > > From: Takashi Iwai <tiwai@suse.de>
> > >=20
> > > commit 242d990c158d5b1dabd166516e21992baef5f26a upstream.
> > >=20
> > > The generic parser accepts the preferred_dacs[] pairs as a hint for
> > > assigning a DAC to each pin, but this hint doesn't work always
> > > effectively.  Currently it's merely a secondary choice after the trial
> > > with the path index failed.  This made sometimes it difficult to
> > > assign DACs without mimicking the connection list and/or the badness
> > > table.
> > >=20
> > > This patch adds a new flag, obey_preferred_dacs, that changes the
> > > behavior of the parser.  As its name stands, the parser obeys the
> >=20
> > Option added is never used as variable is never set. We don't need
> > this in 4.19.
>=20
> Right, it seems that the succeeding fix is queued only for 5.4 and
> 5.9.
>=20
> OTOH, this change will help if another quirk is added in near future,
> and it's pretty safe to apply, so I think it's worth to keep it.

I agree that this is safe to apply and makes sense if we get another
quirk soon. OTOH it is trivial to backport if it is needed.

Best regards,

								Pavel
--=20
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

--tjCHc7DPkfUGtrlw
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAl/T9N4ACgkQMOfwapXb+vJLbACfY1I3Vuk/n8LIY5QyIKk9yTcm
l/8AnRj5OmlyXp9G3TdWxaCeFwMKlkcQ
=GLKi
-----END PGP SIGNATURE-----

--tjCHc7DPkfUGtrlw--