Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1651467pxu; Sat, 12 Dec 2020 22:08:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTTTBioJ3pvzRLOnp4s/cZdWIOWzSW1O+nnSilWYHctAPv/azu4FVoXvQf7zn+PKOhpPLE X-Received: by 2002:a17:906:7784:: with SMTP id s4mr17667042ejm.93.1607839684675; Sat, 12 Dec 2020 22:08:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607839684; cv=none; d=google.com; s=arc-20160816; b=Irp593N+Qd0gzY/6vqPtpvsU/+wWwu/Tg8AIkiWd2rxWwJOZpfKv/tQ7BObQmhGLF6 SJxfbAxyad/a3iKHosuk04E/pXIScm9jqXpqXZqcqpzGueSZS0cE4lw52uwuoWQ3khTZ F5bse/Y3LEqHrEAt8YK6hS2Eqk6RlBB6Ppc7tjNoQ9TlsiX1VsVqlllFHGnnObyAdNYu MYMzb53rpGKzYPSNK81Q5NjBMX0WVAa1F9OzcBFBExkq69ZqKx4EksDroR4Rs1a5DxZq Kx6jrcl/mvEFTCK9+fYp2xRz702tPwqyrTp+FpqQ32xICDDLvZjqNf4zDs34Y5rjotma zIOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:sender:dkim-signature; bh=thwvCtn6LNG/FDpSFGyZ6Wmg72wk3C6bCvqdBXCPvKo=; b=NamCWDelhPTup5zF/lsbfx61DRGJFuJaCiyOT0eA6+imqY2HWDgMWChVtjGDWqKyx5 dkuMmsMYDZa/N/vvt1eeziNXCaCbX42hugaGJ8p+/yBCKZCKaPbD3AXJxxTcWymVhwbz /OK5caRnCgNtQGjX2HzyNN5yZcy5DABANBk7BbfYp9ehqV9617a9v6WzBggoFhQlIiYd OkSZ4wO/QQG1pb1fgr8frPCpqj681EGoPnI/Q0RVX1OmMAT4pedFu05QoLCalGPLf1h3 cQGYZaEi2K/wvoH4yRbLJCGgs5SXbbHVHuDKW3aTKovHHUJrdotcf0PvoNgRgugKC6cW 1afQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=FIuaksvG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l7si8523955edv.409.2020.12.12.22.07.42; Sat, 12 Dec 2020 22:08:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=FIuaksvG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437339AbgLKXfu (ORCPT + 99 others); Fri, 11 Dec 2020 18:35:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391790AbgLKXfE (ORCPT ); Fri, 11 Dec 2020 18:35:04 -0500 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1894CC0617A6 for ; Fri, 11 Dec 2020 15:33:49 -0800 (PST) Received: by mail-pg1-x549.google.com with SMTP id b35so7585315pgl.8 for ; Fri, 11 Dec 2020 15:33:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=thwvCtn6LNG/FDpSFGyZ6Wmg72wk3C6bCvqdBXCPvKo=; b=FIuaksvGvkKtX+5FR+B0iR8RemWNhfGv00aXcmWx8E7IqNojRQ/hCyAgrVB6t4vBvA Dp/sBQYWuuxyY4vOQPLhFsSWuPzY1W2rP9wIeClP0zjHixs0EpW3griB4K22dqhOaPhE O68J55M/2qwYoltluFqVfLAH5GpRu+x+LkteVfKPIxA1MXPtTSlqpTNcoT+2vAt5iOTN AMyrCt82xJZTJaPxS5KCCCQfvyRZ4yUpMo5s2b3mJ/16UWqATWP1yQApz4iTbbjjS5Ty IG9lxEUCtglX9dbAfG2d18aTmeqIBPXKQS+tMjtlVmN884emGJEAFZumdAr0lvcqG/vV +j2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=thwvCtn6LNG/FDpSFGyZ6Wmg72wk3C6bCvqdBXCPvKo=; b=t8P5E+wmkvsxVqoT9NJB6QNqM3bLuvS88D24r6ZEaCq8z47BSSxOSWkN5i1xQrho+S r1AoUFkhCajI3t03SOhUmib5K9QgNRaJ49sSBJiuameu2duLPsI2xgqojFjQ+zXf/GJ8 sCyQ4zUCMoogIZAOW69HT3mWeImofSSrXI5gz9srwwem4gdJ8Sn3eDw8R2Di1gfDEWzg HHWaMuvMQ2FjGamocAAZsvqho0WVvP+ETdCag11U0i27XkQtuWdStnwNmpLD4IMSS//9 K8A0/KEX6letMC3GZrYAVXVWUDBiz22cJs0dQcWBQQFYe9F0FAxfi7cSVIrwryh681VO 5Gig== X-Gm-Message-State: AOAM530XdKfHP08BB3RfvUVTjb4GxcxNqRCF6Yfu14IK+HmrxRuqA3Pu RzkY2wLGbwpZiPXfXhpowoJdigN48W+v Sender: "brianvv via sendgmr" X-Received: from brianvv.c.googlers.com ([fda3:e722:ac3:10:7f:e700:c0a8:348]) (user=brianvv job=sendgmr) by 2002:a62:1d10:0:b029:163:deb3:5df2 with SMTP id d16-20020a621d100000b0290163deb35df2mr13787965pfd.68.1607729628547; Fri, 11 Dec 2020 15:33:48 -0800 (PST) Date: Fri, 11 Dec 2020 23:33:39 +0000 In-Reply-To: <20201211233340.1503242-1-brianvv@google.com> Message-Id: <20201211233340.1503242-4-brianvv@google.com> Mime-Version: 1.0 References: <20201211233340.1503242-1-brianvv@google.com> X-Mailer: git-send-email 2.29.2.576.ga3fc446d84-goog Subject: [PATCH net-next v2 3/4] net: use indirect call helpers for dst_mtu From: Brian Vazquez To: Brian Vazquez , Brian Vazquez , Eric Dumazet , "David S . Miller" Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: brianvv This patch avoids the indirect call for the common case: ip6_mtu and ipv4_mtu Signed-off-by: brianvv --- include/net/dst.h | 4 +++- net/ipv4/route.c | 6 ++++-- net/ipv6/route.c | 6 ++++-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/include/net/dst.h b/include/net/dst.h index 3932e9931f08..9f474a79ed7d 100644 --- a/include/net/dst.h +++ b/include/net/dst.h @@ -194,9 +194,11 @@ dst_feature(const struct dst_entry *dst, u32 feature) return dst_metric(dst, RTAX_FEATURES) & feature; } +INDIRECT_CALLABLE_DECLARE(unsigned int ip6_mtu(const struct dst_entry *)); +INDIRECT_CALLABLE_DECLARE(unsigned int ipv4_mtu(const struct dst_entry *)); static inline u32 dst_mtu(const struct dst_entry *dst) { - return dst->ops->mtu(dst); + return INDIRECT_CALL_INET(dst->ops->mtu, ip6_mtu, ipv4_mtu, dst); } /* RTT metrics are stored in milliseconds for user ABI, but used as jiffies */ diff --git a/net/ipv4/route.c b/net/ipv4/route.c index e26652ff7059..4fac91f8bd6c 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -135,7 +135,8 @@ static int ip_rt_gc_timeout __read_mostly = RT_GC_TIMEOUT; static struct dst_entry *ipv4_dst_check(struct dst_entry *dst, u32 cookie); static unsigned int ipv4_default_advmss(const struct dst_entry *dst); -static unsigned int ipv4_mtu(const struct dst_entry *dst); +INDIRECT_CALLABLE_SCOPE +unsigned int ipv4_mtu(const struct dst_entry *dst); static struct dst_entry *ipv4_negative_advice(struct dst_entry *dst); static void ipv4_link_failure(struct sk_buff *skb); static void ip_rt_update_pmtu(struct dst_entry *dst, struct sock *sk, @@ -1311,7 +1312,7 @@ static unsigned int ipv4_default_advmss(const struct dst_entry *dst) return min(advmss, IPV4_MAX_PMTU - header_size); } -static unsigned int ipv4_mtu(const struct dst_entry *dst) +INDIRECT_CALLABLE_SCOPE unsigned int ipv4_mtu(const struct dst_entry *dst) { const struct rtable *rt = (const struct rtable *)dst; unsigned int mtu = rt->rt_pmtu; @@ -1333,6 +1334,7 @@ static unsigned int ipv4_mtu(const struct dst_entry *dst) return mtu - lwtunnel_headroom(dst->lwtstate, mtu); } +EXPORT_SYMBOL(ipv4_mtu); static void ip_del_fnhe(struct fib_nh_common *nhc, __be32 daddr) { diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 188e114b29b4..22caee290b6c 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -83,7 +83,8 @@ enum rt6_nud_state { static struct dst_entry *ip6_dst_check(struct dst_entry *dst, u32 cookie); static unsigned int ip6_default_advmss(const struct dst_entry *dst); -static unsigned int ip6_mtu(const struct dst_entry *dst); +INDIRECT_CALLABLE_SCOPE +unsigned int ip6_mtu(const struct dst_entry *dst); static struct dst_entry *ip6_negative_advice(struct dst_entry *); static void ip6_dst_destroy(struct dst_entry *); static void ip6_dst_ifdown(struct dst_entry *, @@ -3089,7 +3090,7 @@ static unsigned int ip6_default_advmss(const struct dst_entry *dst) return mtu; } -static unsigned int ip6_mtu(const struct dst_entry *dst) +INDIRECT_CALLABLE_SCOPE unsigned int ip6_mtu(const struct dst_entry *dst) { struct inet6_dev *idev; unsigned int mtu; @@ -3111,6 +3112,7 @@ static unsigned int ip6_mtu(const struct dst_entry *dst) return mtu - lwtunnel_headroom(dst->lwtstate, mtu); } +EXPORT_SYMBOL(ip6_mtu); /* MTU selection: * 1. mtu on route is locked - use it -- 2.29.2.576.ga3fc446d84-goog