Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1801708pxu; Sun, 13 Dec 2020 04:02:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJyFGvRP27hME53TK9GNTJZZoYNZP7Id/HSMabUxUC5J5rpY4j5hTa5a3d4JXIrKgjTH+rz4 X-Received: by 2002:a05:6402:1d13:: with SMTP id dg19mr20321861edb.111.1607860969224; Sun, 13 Dec 2020 04:02:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607860969; cv=none; d=google.com; s=arc-20160816; b=frpRx1umR+mSkCfrHbr2wRI2Tk/mPgsEldvUOnN7GN7IUJn0FLEOgGEDPgSfvbJ0P6 yD6LnBMQ8HMR2RIqsOmf1WIg0o4wtdXAYrthop+T2O3VVgZG/IU2h+esYwyzkcgGJERv OOBpXcy/YcIJsqOeQlOR0VdLFEVuWnhKCXMfcnLm/1XtDLqEX75UJLHRlUUSIJNHNvUS oyrR5YHC4qlh6lM+AaujVjL0zAxMD2grZIS1BrAGq/5kyAGbjEiT+53kBTTuWIpNcTfb qiz7QxxWi2Js9LqtP12Qi3k4fzkAd73PiR86IFsktnWaxaBThC82woxk+0fZJAgvTnNg B7fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Sj3sGpvqM/eIAz41u51RukA4uaqw2LCqwPcZJtduoN8=; b=rkh94Gm7DABrzhU7E55AqwtfQMb1ak/JIAt07MC5dXxbzW06DiJmRwtRBKnLatCS4/ wmBNU2FXKR5oaM5MNyE2525NJABUodi13P6azWOZla6GHan4eYodpnMm248iwwPf34B4 q4VuMa4dP3iR9556Euuu71btTkSF+WviJmtu5tzB0JCQjTr7xYBDJfcPzOR4nLtzvU4x T5YN9+pGWtmZWQxp0PBtWYOAYbH+GmM0ml+b2oJWR9ju/D2Z2dp+P1Us1DXhW4O3LXFU 9/2BIldN0fthunbw0Xt3I4t7ITWC+JKyVGk0km5h0CnlVcjP2AsSZ9+zpOIrwZ6J5VR7 onzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=b0f10Clh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j7si9166582ejm.496.2020.12.13.04.01.55; Sun, 13 Dec 2020 04:02:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=b0f10Clh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406296AbgLKVvM (ORCPT + 99 others); Fri, 11 Dec 2020 16:51:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391893AbgLKVum (ORCPT ); Fri, 11 Dec 2020 16:50:42 -0500 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5437EC0613CF; Fri, 11 Dec 2020 13:50:02 -0800 (PST) Received: by mail-pg1-x541.google.com with SMTP id n7so8058436pgg.2; Fri, 11 Dec 2020 13:50:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Sj3sGpvqM/eIAz41u51RukA4uaqw2LCqwPcZJtduoN8=; b=b0f10ClhDPraZ6YR05aT5JpL/eimcmNKtp/aqZ+h8Hf2KrqKOSXnldQjz1V0VX3ad8 lGJFS5gNaOaVDaNdOFb+d0EUZOxHWyRTP25CbiI1j/hsnR6PbZzIHbt8/EpfN77rPIgK fZj/HvADFT0cudlUWR8+zEE0M6YVVNcqfQCTNjNkaVrs5Zp61RExJy25to4Xw9CG78Tw tyDdJJ+art2qMHIRgkC+Efc3axnHv8Dv5SkpX02TOu8RzbU/h9+TnquUk25nTl/7oiqG 0k8QRIrYTc2tSPsSLDXie2NoSO/hiELM3W5zzobqL8Ga99a5fN6/vBfwb/mrPbyz+pZ/ WLwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Sj3sGpvqM/eIAz41u51RukA4uaqw2LCqwPcZJtduoN8=; b=Ey02T8c2vOsy43FKN/jy8TLBYMiOq+yFEDcKvLttkR9r+tfHXJbKGEPVpjq8M3Kc7e +zRxiI4GoGTySyASseQTyajha6U78tk5bBjuM9jlKXZVfKSAiGF7EuHlu51md8DOdHJ/ RkOv7pOpKaJF5GwylEOALJCoBxjHTqgqDmsPkW4EfWDxbdRSSDp7sy1/LgAQuiaEghhc mvfKdSiO/L47J8QMsYsWkchhKLNAqGgYuyRWK8T1B+CSzE3R8adiehW2lyfRRnctXGnS 5mca05bc4u+oh/0zrkFtuJtBfrA1yKrta9dVoZXXpLwz+tW2YYw76PzFusH9w3u+4yzP +wZw== X-Gm-Message-State: AOAM531/W82EBg9AVWw6pKM7CvvM6uCNGgVS0jXHOb36Jc8bxVynvtrX pg9HEnoVoTeva2yFHdVyQU6hPZuNMfk= X-Received: by 2002:a63:a516:: with SMTP id n22mr13520125pgf.125.1607723401806; Fri, 11 Dec 2020 13:50:01 -0800 (PST) Received: from google.com ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id p127sm11522996pfp.93.2020.12.11.13.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 13:50:00 -0800 (PST) Date: Fri, 11 Dec 2020 13:49:58 -0800 From: Dmitry Torokhov To: "jingle.wu" Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, phoenix@emc.com.tw, josh.chen@emc.com.tw, dave.wang@emc.com.tw Subject: Re: [PATCH 2/2] Input: elantech - Some module tp of tracpoint report has a smbus protocol error. Message-ID: References: <20201211071531.32413-1-jingle.wu@emc.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201211071531.32413-1-jingle.wu@emc.com.tw> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 11, 2020 at 03:15:31PM +0800, jingle.wu wrote: > 1. Add the conditional expression to distinguish different patterns regarding 0, 1, 2. > 2. Add the function to get or set more bytes from register > 3. Get and correct the device informations including ic_type, module id from different pattern. > 4. Add the function to change the report id 0x5F of trackpoint. > 5. Some module has a bug which makes default SMBUS trackpoint report 0x5E has a smbus protocol error. > > Signed-off-by: Jingle Wu Applied with a few minor edits. -- Dmitry