Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1889630pxu; Sun, 13 Dec 2020 06:41:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJz3iOiyy0dFCcGrV/5H5JSN8VMM44vyx17uP/y6UrPMI4G1ljZ1U+KS/xfEkd1cxjPV+owj X-Received: by 2002:a17:906:5002:: with SMTP id s2mr18278911ejj.16.1607870460361; Sun, 13 Dec 2020 06:41:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607870460; cv=none; d=google.com; s=arc-20160816; b=bHXnCn6aqNdMPdtgXDil8dGql4qyKGYuQLHrQ78695FUO8JUitMHIAZVNH8R2pIINd 18ApYO1FHAGtP46xa3IZxJp7ErzamSRh450xVoapbaDmWRZA3Fsqis5wZbq9ugdgSBZD NilDzHvwtKcAsp4G7CwBdVKamyqsRkWi0kSocsnml7Yt29NuAPCo/lDbYoIBiErtu5Dr T/NKNcic9vuh433/ijz6Hb19B4D9LBjJ6j4a9HO8AZJGMSBJCKHrdApLkKDtbWY8kzhw /AiXwn5npO3Sczd0v1XE/MIZ1RWCYoy8hHtihwfYjd48SYu1zwhLAgf49tomy+DJieoG fEZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=hYZSVCjgqXKtM8w9BwAb1e1KcOhU0SGPdZRd58OQmRs=; b=VaJqy281FTeIqKEjdUBQbb00NwGCAWeEOmwNgEChpLbkkF+z6n+fYYOfSSEPZH5UIA /DBw8wFSu1VaIHLLxD5UZfVYgEY5ojgvFzBgW3weNHTcda0XHhbGKMkyDxhMq+q1GGYg gWn82vq6UZHKOGSg9JCnBzbY045ko3lPuocGj3x6BNlSxy38AVTSfRMI479XMhmz7GKh 2uIR2cCOBTxKA0xlnIQW1IGht0WoGvSM4yH/Pv+NgbtC6b8H/sxtjcghb8ZJ+av4Y4XX rXvsPyPpWNmMhRVGx+nBCF2ERLniAl9KzJC/2BwoHIBX6MBmX9noEsPs8toS+kPl2cjf cYFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pKxu+obP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b22si7978330ejk.400.2020.12.13.06.40.37; Sun, 13 Dec 2020 06:41:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pKxu+obP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438688AbgLLKMI (ORCPT + 99 others); Sat, 12 Dec 2020 05:12:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405248AbgLLJyA (ORCPT ); Sat, 12 Dec 2020 04:54:00 -0500 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1001C0619D8; Sat, 12 Dec 2020 01:39:58 -0800 (PST) Received: by mail-io1-xd42.google.com with SMTP id q137so12046933iod.9; Sat, 12 Dec 2020 01:39:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hYZSVCjgqXKtM8w9BwAb1e1KcOhU0SGPdZRd58OQmRs=; b=pKxu+obPNk7a6SYH3xsDSt9agGgQZDuXzchVjSYTXgwLjARonlnuEGrm0W8cep4KiV pZ6Hw2bwsHjcWiCbt28qizIlyUtAMdcoihnbQnzcbntdmT7Rvnl0t8c/Gt5wiS8DxOeP 1iggijddzfqkYPRaWE7CN1x6gHG3Lwv33dLJAsxQbilBbNl9SJj1fxtgk+x4k1tHpE8u RmuuBwnd8FNsEXX5YRGf3JrTdl8NZ/xqnDJcfs4ADrMvr9YM9woWdWD4UGNcNyCMyRDH BliWGJIhb0svXU6lKpUilyzj/VsLI43NSzurW15Qv9s72uakm+6ZbM3z9lIRfsmhmwLv sOuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hYZSVCjgqXKtM8w9BwAb1e1KcOhU0SGPdZRd58OQmRs=; b=hCVuA60IdAwIiOUNe5lvLV/fvec5Zj7n9KTWLlzUU46KSMWJhzEV6TmR6sYWMtGhgG VxZmtzWLnYSNuSnigkRX3iWdqo2ZH30Dmt7pQr8Fs9fGz+xxuEjMzAgzFfnjXSHIVeSn d7ynQMQQ177CiNPaY7rU99KhEdS4NrjsYgBaAxvY1K6Yn5Ru8Bxe4RbgcDOhKrjLGVrL 7md8Mi1GSabyEoezfz6s7p9yUV5vJNyTaWUEXrMXLIpbRr1ilMCwiJDWld9ODkY3TE9n +GiAVPiICyQ4/w85QSKCNqwqG4sYTTlP5ibAoGB0l2W+cuURYLraWa6CZ0GWwmT4JxEU DfhQ== X-Gm-Message-State: AOAM531O14l+7ApM0lC57J7ubm4fHRbLxt1BS7IrAyroDeeP4fY0Uvb+ ej7a+I1kSQ1bK4RnWZQoJ1DGWEYuRGxtioggPHY= X-Received: by 2002:a05:6602:14c5:: with SMTP id b5mr20317154iow.44.1607765998041; Sat, 12 Dec 2020 01:39:58 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Syed Nayyar Waris Date: Sat, 12 Dec 2020 15:09:46 +0530 Message-ID: Subject: Re: [RESEND PATCH 3/4] gpio: xilinx: Modify bitmap_set_value() calls To: Bartosz Golaszewski Cc: Andrew Morton , Andy Shevchenko , William Breathitt Gray , Michal Simek , Arnd Bergmann , Robert Richter , Linus Walleij , Masahiro Yamada , Zhang Rui , Daniel Lezcano , Amit Kucheria , Linux-Arch , linux-gpio , LKML , arm-soc , linux-pm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 1, 2020 at 9:03 PM Bartosz Golaszewski wrote: > > On Fri, Nov 20, 2020 at 7:46 PM Syed Nayyar Waris wrote: > > > > Modify the bitmap_set_value() calls. bitmap_set_value() > > now takes an extra bitmap width as second argument and the width of > > value is now present as the fourth argument. > > > > Cc: Michal Simek > > Signed-off-by: Syed Nayyar Waris > > --- > > drivers/gpio/gpio-xilinx.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c > > index ad4ee4145db4..05dae086c4d0 100644 > > --- a/drivers/gpio/gpio-xilinx.c > > +++ b/drivers/gpio/gpio-xilinx.c > > @@ -151,16 +151,16 @@ static void xgpio_set_multiple(struct gpio_chip *gc, unsigned long *mask, > > spin_lock_irqsave(&chip->gpio_lock[0], flags); > > spin_lock(&chip->gpio_lock[1]); > > > > - bitmap_set_value(old, state[0], 0, width[0]); > > - bitmap_set_value(old, state[1], width[0], width[1]); > > + bitmap_set_value(old, 64, state[0], width[0], 0); > > + bitmap_set_value(old, 64, state[1], width[1], width[0]); > > bitmap_replace(new, old, bits, mask, gc->ngpio); > > > > - bitmap_set_value(old, state[0], 0, 32); > > - bitmap_set_value(old, state[1], 32, 32); > > + bitmap_set_value(old, 64, state[0], 32, 0); > > + bitmap_set_value(old, 64, state[1], 32, 32); > > state[0] = bitmap_get_value(new, 0, width[0]); > > state[1] = bitmap_get_value(new, width[0], width[1]); > > - bitmap_set_value(new, state[0], 0, 32); > > - bitmap_set_value(new, state[1], 32, 32); > > + bitmap_set_value(new, 64, state[0], 32, 0); > > + bitmap_set_value(new, 64, state[1], 32, 32); > > bitmap_xor(changed, old, new, 64); > > > > if (((u32 *)changed)[0]) > > -- > > 2.29.0 > > > > This series is not bisectable because you modify the interface - > breaking existing users - and you only fix them later. Please squash > those changes into a single commit. > > Bartosz Hi Bartosz, I have squashed the changes and have sent a new patchset v2. Regards Syed Nayyar Waris