Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201211150157.91399-1-ldufour@linux.ibm.com>
In-Reply-To: <20201211150157.91399-1-ldufour@linux.ibm.com>
From:   Souptick Joarder <jrdr.linux@gmail.com>
Date:   Sat, 12 Dec 2020 20:34:10 +0530
Message-ID: <CAFqt6zbpWyaJmTGjXcHzdU8+Vow=Kawe6K=UGb4zW0sJJ0LKmg@mail.gmail.com>
Subject: Re: [PATCH] mm/memory_hotplug: quieting offline operation
To:     Laurent Dufour <ldufour@linux.ibm.com>
Cc:     Linux-MM <linux-mm@kvack.org>, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        nathanl@linux.ibm.com, cheloha@linux.ibm.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Dec 11, 2020 at 8:32 PM Laurent Dufour <ldufour@linux.ibm.com> wrote:
>
> On PowerPC, when dymically removing memory from a system we can see in the console a
> lot of messages like this:
> [  186.575389] Offlined Pages 4096

Is it specific to PowerPC ?

>
> This message is displayed on each LMB (256MB) removed, which means that we
> removing 1TB of memory, this message is displayed 4096 times.
>
> Moving it to DEBUG to not flood the console.
>
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
> ---
>  mm/memory_hotplug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index b44d4c7ba73b..c47a53a16782 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1587,7 +1587,7 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages)
>
>         /* Mark all sections offline and remove free pages from the buddy. */
>         __offline_isolated_pages(start_pfn, end_pfn);
> -       pr_info("Offlined Pages %ld\n", nr_pages);
> +       pr_debug("Offlined Pages %ld\n", nr_pages);
>
>         /*
>          * The memory sections are marked offline, and the pageblock flags
> --
> 2.29.2
>
>