Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] platform: surface: fix non-PM_SLEEP build warnings
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Maximilian Luz <luzmaximilian@gmail.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Platform Driver <platform-driver-x86@vger.kernel.org>
References: <20201211190335.16501-1-rdunlap@infradead.org>
 <CAHp75Vcckb5NA=tc5s5p_qzYE2qhJOT0vhCtfKhT_eqZe+PgXw@mail.gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <ec8e703f-e1ea-1253-edc9-311f0ee3e8fd@infradead.org>
Date:   Sat, 12 Dec 2020 09:05:01 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <CAHp75Vcckb5NA=tc5s5p_qzYE2qhJOT0vhCtfKhT_eqZe+PgXw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/12/20 5:24 AM, Andy Shevchenko wrote:
> On Fri, Dec 11, 2020 at 9:20 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> Fix build warnings when CONFIG_PM_SLEEP is not enabled and these
>> functions are not used:
>>
>> ../drivers/platform/surface/surface_gpe.c:189:12: warning: ‘surface_gpe_resume’ defined but not used [-Wunused-function]
>>  static int surface_gpe_resume(struct device *dev)
>>             ^~~~~~~~~~~~~~~~~~
>> ../drivers/platform/surface/surface_gpe.c:184:12: warning: ‘surface_gpe_suspend’ defined but not used [-Wunused-function]
>>  static int surface_gpe_suspend(struct device *dev)
>>             ^~~~~~~~~~~~~~~~~~~
> 
> ...
> 
>> +#ifdef CONFIG_PM_SLEEP
>>  static int surface_gpe_suspend(struct device *dev)
> 
> Perhaps __maybe_unused ?
> 

Yes, I am aware of that option.
I don't know why it would be preferred though.

-- 
~Randy