Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Sun, 13 Dec 2020 08:16:33 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     Johan Jonker <jbx6244@gmail.com>
Cc:     heiko@sntech.de, robh+dt@kernel.org, wim@linux-watchdog.org,
        jamie@jamieiles.com, linux-watchdog@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-binding: watchdog: add Rockchip compatibles to
 snps,dw-wdt.yaml
Message-ID: <20201213161633.GA44820@roeck-us.net>
References: <20201116142539.12377-1-jbx6244@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201116142539.12377-1-jbx6244@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Mon, Nov 16, 2020 at 03:25:39PM +0100, Johan Jonker wrote:
> The Rockchip watchdog compatibles below are already in use,
> but somehow never added to a document,
> so add them to the snps,dw-wdt.yaml file.
> 
> "rockchip,rk3066-wdt", "snps,dw-wdt"
> "rockchip,rk3188-wdt", "snps,dw-wdt"
> "rockchip,rk3288-wdt", "snps,dw-wdt"
> "rockchip,rk3368-wdt", "snps,dw-wdt"
> 
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> index d9fc7bb85..f7ee9229c 100644
> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> @@ -14,7 +14,15 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: snps,dw-wdt
> +    oneOf:
> +      - const: snps,dw-wdt
> +      - items:
> +          - enum:
> +              - rockchip,rk3066-wdt
> +              - rockchip,rk3188-wdt
> +              - rockchip,rk3288-wdt
> +              - rockchip,rk3368-wdt
> +          - const: snps,dw-wdt
>  
>    reg:
>      maxItems: 1