Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5FD64F9A.3040807@gmail.com>
Date:   Sun, 13 Dec 2020 19:30:02 +0200
From:   Eli Billauer <eli.billauer@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7
MIME-Version: 1.0
To:     Randy Dunlap <rdunlap@infradead.org>
CC:     gregkh@linuxfoundation.org, arnd@arndb.de,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant
 for USB)
References: <20201213170503.59017-1-eli.billauer@gmail.com> <c661c10e-fa21-d3e5-9d94-6f8f2d89f1d0@infradead.org>
In-Reply-To: <c661c10e-fa21-d3e5-9d94-6f8f2d89f1d0@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Randy,

The new driver doesn't depend on XILLYBUS, so the patch puts it 
correctly outside the "if XILLYBUS" clause. It indeed looks like a 
mistake, but it isn't. :)

Thanks for paying attention to this.

Regards,
     Eli

On 13/12/20 19:22, Randy Dunlap wrote:
> On 12/13/20 9:05 AM, eli.billauer@gmail.com wrote:
>    
>> diff --git a/drivers/char/xillybus/Kconfig b/drivers/char/xillybus/Kconfig
>> index 130dbdce858f..18fa99ec1029 100644
>> --- a/drivers/char/xillybus/Kconfig
>> +++ b/drivers/char/xillybus/Kconfig
>> @@ -32,3 +32,14 @@ config XILLYBUS_OF
>>   	  system, say M.
>>
>>   endif # if XILLYBUS
>> +
>>      
> Hi Eli,
>
> You don't want this new part inside the "if XILLYBUS" block above?
> IOW, XILLYUSB does not need XILLYBUS?
>
>    
>> +config XILLYUSB
>> +	tristate "XillyUSB: Xillybus generic FPGA interface for USB"
>> +	depends on USB
>> +	select CRC32
>> +	help
>> +	  XillyUSB is the Xillybus variant which uses USB for communicating
>> +	  with the FPGA.
>> +
>> +	  Set to M if you want Xillybus to use USB for communicating with
>> +	  the FPGA.
>>      
> thanks.
>