Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201212165648.166220-1-aford173@gmail.com> <7f5f8ef2-3e4f-5076-0558-26b48e75b674@gmail.com>
In-Reply-To: <7f5f8ef2-3e4f-5076-0558-26b48e75b674@gmail.com>
From:   Adam Ford <aford173@gmail.com>
Date:   Sat, 12 Dec 2020 13:38:09 -0600
Message-ID: <CAHCN7xKbcO0-h1mEWe7vZYdJ6bQ8_KzN-MpFRhDbBVpQznAMzg@mail.gmail.com>
Subject: Re: [RFC] ravb: Add support for optional txc_refclk
To:     Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc:     Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        Adam Ford-BE <aford@beaconembedded.com>,
        Charles Stevens <charles.stevens@logicpd.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Dec 12, 2020 at 11:55 AM Sergei Shtylyov
<sergei.shtylyov@gmail.com> wrote:
>
> Hello!
>
> On 12.12.2020 19:56, Adam Ford wrote:
>
> > The SoC expects the txv_refclk is provided, but if it is provided
> > by a programmable clock, there needs to be a way to get and enable
> > this clock to operate.  It needs to be optional since it's only
> > necessary for those with programmable clocks.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> [...]
> > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> > index bd30505fbc57..4c3f95923ef2 100644
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> > @@ -2148,6 +2148,18 @@ static int ravb_probe(struct platform_device *pdev)
> >               goto out_release;
> >       }
> >
> > +     priv->ref_clk = devm_clk_get(&pdev->dev, "txc_refclk");
>
>     Why not devm_clk_get_optional()?

I am not that familiar with the clock API.  I'll look into that
function. It looks like it makes more sense.  I'll send a V2.

adam
>
> > +     if (IS_ERR(priv->ref_clk)) {
> > +             if (PTR_ERR(priv->ref_clk) == -EPROBE_DEFER) {
> > +                     /* for Probe defer return error */
> > +                     error = PTR_ERR(priv->ref_clk);
> > +                     goto out_release;
> > +             }
> > +             /* Ignore other errors since it's optional */
> > +     } else {
> > +             (void)clk_prepare_enable(priv->ref_clk);
> > +     }
> > +
> >       ndev->max_mtu = 2048 - (ETH_HLEN + VLAN_HLEN + ETH_FCS_LEN);
> >       ndev->min_mtu = ETH_MIN_MTU;
> >
>
> MBR, Sergei