Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Michael Kelley <mikelley@microsoft.com>
To:     "Andrea Parri (Microsoft)" <parri.andrea@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        Andres Beltran <lkmlabelt@gmail.com>,
        Saruhan Karademir <skarade@microsoft.com>,
        Juan Vazquez <juvazq@microsoft.com>
Subject: RE: [PATCH v4] hv_utils: Add validation for untrusted Hyper-V values
Thread-Topic: [PATCH v4] hv_utils: Add validation for untrusted Hyper-V values
Thread-Index: AQHWtoAcDIEWdt1fOkqLya2qviZkrqn1yz0A
Date:   Sun, 13 Dec 2020 22:07:06 +0000
Message-ID: <MW2PR2101MB105203EB0E4889F2C716CE83D7C89@MW2PR2101MB1052.namprd21.prod.outlook.com>
References: <20201109100704.9152-1-parri.andrea@gmail.com>
In-Reply-To: <20201109100704.9152-1-parri.andrea@gmail.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-12-13T22:07:04Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=edb22038-260e-4889-906e-4ecc6a8c388f;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0
authentication-results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=microsoft.com;
x-originating-ip: [24.22.167.197]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 98f87a9b-56a0-4ce4-cd11-08d89fb36dfe
x-ms-traffictypediagnostic: MW4PR21MB1858:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MW4PR21MB1858F8C37E90252D762AF55FD7C89@MW4PR21MB1858.namprd21.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2958;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: y5fHqQjoE+553nsgpo4DjDwUMv/kBcLbFK+wDHN3x8pHn+8h+O58DexjMBVpbN3KtXSq0TlHygS312A7OU0Ymm8x2qF/sOq5ZsVJjbwnC/g2pRrkX/gYDcVY8wySVNrbk2S5PNu740vwgKQN+b/RGWDeUkDWhNmRNQBUIr+gTxI220+f/kCm21ST7HTB67OwJpDjCZ4v/PUvJ/xvHbYI3fw2eDEDCaDEZJu/03Rk0QjN++NHfC4hhbkVquaDuXxkuSEoTo5zM1UkgzIHtBepgjfBnKXqxo4TQD89GZ+xAmXeJYTS7BqW8Q5JEUB+jdcMegqBGJnFpt/myUhRSUUq4x6q9dM9j0j+MIOovyWCSxNOS+IWcinkc1iLhwNyVSihVUTWjTJwH+xux8KrxM1/oQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR2101MB1052.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(346002)(376002)(5660300002)(33656002)(86362001)(2906002)(8936002)(8990500004)(110136005)(83380400001)(10290500003)(7696005)(508600001)(9686003)(76116006)(66476007)(66946007)(54906003)(52536014)(8676002)(26005)(186003)(66446008)(64756008)(55016002)(6506007)(71200400001)(82960400001)(82950400001)(4326008)(66556008)(107886003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?uunXObMMOwLPtV/yDntodWWozmV44PicQ5ycO5tzhlajJYvE3R7UhW6s8Rfp?=
 =?us-ascii?Q?3ddDrp3//WLfldy2k08y+B/NNUofU9lhhC+1OH/CXx8SsLCrQBQlrbqHrBGp?=
 =?us-ascii?Q?KYIjDRtHzbe/2GelAxadcGrtxdw/kox3tKaprgiOSASiyi5gpbfoV2+ahalK?=
 =?us-ascii?Q?+TOYfzQt3gBs3Iknzbqb7P4y+7BOEwGwkhdM8FBNre1cSYP4chhYUrTdLsTZ?=
 =?us-ascii?Q?oeFL5QYpCdRSmZnBBRhUdLlWsv7qFzA65eXPndzfE+2b/jvUm1eKveLO44yw?=
 =?us-ascii?Q?N9BiZtDJIt4rBWoIHPAc2qu/T6GWWSQ2s/EQLEEHch+cKkCtz5QPkdRGkOGT?=
 =?us-ascii?Q?K+WHDQvasXC6g2EP1/WGdwtBYbTwijt1DRb+Iz2wvZ8IDeLKlCVhc2bmJjKa?=
 =?us-ascii?Q?uwDz/qUHZahXVedLr4jRrKN4/k+uMre0Nvdqcy47cb/+mBTvbbg7MbKTlX+P?=
 =?us-ascii?Q?XkkcgdP3nMnZuf04o/0hCZglgcyxkPbIokx4XAiSZbWAv5yEnY2HZAyUQtYX?=
 =?us-ascii?Q?1Zdb2wxBQQqGczFU1qGXVyIeEu9LhUfPFwXTeKzWpAX+FUglS8hP+0657SdT?=
 =?us-ascii?Q?0XPtaOIDPR9Mp+gokTqOHx6KGhqx4IQlJIyKyPqzPYtxbY5XMwEb25wxrH4P?=
 =?us-ascii?Q?OWiVm+Jjiq88E7p6SUhtJQ7u4z8NgYM1JepDgOulh7yaw0ZRqi4EStx9KjzF?=
 =?us-ascii?Q?fyv805aR4Z0UgcslGNUVWDPOnO2M6ffbBkghr8PKGK7ykKNonvRzlWgrTMBJ?=
 =?us-ascii?Q?O3RD8nozJTT6vebh8HY/GVQxsw+z/xooVopbUw4RbrganXprfBVv+y5agsJ/?=
 =?us-ascii?Q?9JJRNvHemTy9p5CJixxzaXl4ZA1SoJWZOyFmy5wNcwJw+kGp97R/2YGVsNCh?=
 =?us-ascii?Q?Yj3sIwpA95kkTrlv8Ok5+UIyaAdQ3TlbhgH/d9Pv3LJPIKmHYfL3Q2J1W7Km?=
 =?us-ascii?Q?9uheCnzmMfpe8z1Eqh/pKDx4WlbuQvyClKKHtiIbk74=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR2101MB1052.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98f87a9b-56a0-4ce4-cd11-08d89fb36dfe
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2020 22:07:06.4663
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CTUduztC41OOn4885uMZ1p170fFOGxIZ/xMgm9nyLMqDExg7sLoQA9ZalPkkRYQgiSE9ezB8U3CwUKrVpFIYjbtwe1GiZpPkmnJS7VWjrrQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR21MB1858
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Andrea Parri (Microsoft) <parri.andrea@gmail.com> Sent: Monday, Novem=
ber 9, 2020 2:07 AM
>=20
> For additional robustness in the face of Hyper-V errors or malicious
> behavior, validate all values that originate from packets that Hyper-V
> has sent to the guest in the host-to-guest ring buffer. Ensure that
> invalid values cannot cause indexing off the end of the icversion_data
> array in vmbus_prep_negotiate_resp().
>=20
> Signed-off-by: Andres Beltran <lkmlabelt@gmail.com>
> Co-developed-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
> Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
> ---
> Changes in v3:
> 	- Add size check for icframe_vercnt and icmsg_vercnt
>=20
> Changes in v2:
> 	- Use ratelimited form of kernel logging to print error messages
>=20
>  drivers/hv/channel_mgmt.c |  24 ++++-
>  drivers/hv/hv_fcopy.c     |  36 +++++--
>  drivers/hv/hv_kvp.c       | 122 ++++++++++++---------
>  drivers/hv/hv_snapshot.c  |  89 ++++++++-------
>  drivers/hv/hv_util.c      | 222 +++++++++++++++++++++++---------------
>  include/linux/hyperv.h    |   9 +-
>  6 files changed, 314 insertions(+), 188 deletions(-)
>=20

Reviewed-by:  Michael Kelley <mikelley@microsoft.com>