Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mm/memory_hotplug: quieting offline operation
To:     Souptick Joarder <jrdr.linux@gmail.com>
Cc:     Linux-MM <linux-mm@kvack.org>, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        nathanl@linux.ibm.com, cheloha@linux.ibm.com
References: <20201211150157.91399-1-ldufour@linux.ibm.com>
 <CAFqt6zbpWyaJmTGjXcHzdU8+Vow=Kawe6K=UGb4zW0sJJ0LKmg@mail.gmail.com>
From:   Laurent Dufour <ldufour@linux.ibm.com>
Message-ID: <f6454d1d-cdc4-bacb-bd9b-12e1baf6ceba@linux.ibm.com>
Date:   Mon, 14 Dec 2020 10:30:15 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.5.1
MIME-Version: 1.0
In-Reply-To: <CAFqt6zbpWyaJmTGjXcHzdU8+Vow=Kawe6K=UGb4zW0sJJ0LKmg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 12/12/2020 à 16:04, Souptick Joarder a écrit :
> On Fri, Dec 11, 2020 at 8:32 PM Laurent Dufour <ldufour@linux.ibm.com> wrote:
>>
>> On PowerPC, when dymically removing memory from a system we can see in the console a
>> lot of messages like this:
>> [  186.575389] Offlined Pages 4096
> 
> Is it specific to PowerPC ?

No, this applies to all architectures, but this is surfacing a bit more on 
PowerPC where the memory block size is set to 256MB currently by the firmware.

> 
>>
>> This message is displayed on each LMB (256MB) removed, which means that we
>> removing 1TB of memory, this message is displayed 4096 times.
>>
>> Moving it to DEBUG to not flood the console.
>>
>> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
>> ---
>>   mm/memory_hotplug.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
>> index b44d4c7ba73b..c47a53a16782 100644
>> --- a/mm/memory_hotplug.c
>> +++ b/mm/memory_hotplug.c
>> @@ -1587,7 +1587,7 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages)
>>
>>          /* Mark all sections offline and remove free pages from the buddy. */
>>          __offline_isolated_pages(start_pfn, end_pfn);
>> -       pr_info("Offlined Pages %ld\n", nr_pages);
>> +       pr_debug("Offlined Pages %ld\n", nr_pages);
>>
>>          /*
>>           * The memory sections are marked offline, and the pageblock flags
>> --
>> 2.29.2
>>
>>