Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 14 Dec 2020 11:37:04 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Icenowy Zheng <icenowy@aosc.io>
Cc:     Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        Ondrej Jirman <megous@megous.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/3] dt-bindings: arm: sunxi: add PineTab new panel DT
 binding
Message-ID: <20201214103704.bkgwh4bdelrtovgd@gilmour>
References: <20201210083722.1912981-1-icenowy@aosc.io>
 <20201210084232.1913871-1-icenowy@aosc.io>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="jypi6ln6e6jthjwh"
Content-Disposition: inline
In-Reply-To: <20201210084232.1913871-1-icenowy@aosc.io>
Precedence: bulk


--jypi6ln6e6jthjwh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 10, 2020 at 04:42:32PM +0800, Icenowy Zheng wrote:
> Early adopters' PineTabs (and all further releases) will have a new LCD
> panel different with the one that is used when in development (because
> the old panel's supply discontinued).
>=20
> Add a new DT compatible for it.
>=20
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documenta=
tion/devicetree/bindings/arm/sunxi.yaml
> index 6db32fbf813f..73a6c8421172 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -700,6 +700,11 @@ properties:
>            - const: pine64,pinetab
>            - const: allwinner,sun50i-a64
> =20
> +      - description: Pine64 PineTab with new LCD panel
> +        items:
> +          - const: pine64,pinetab-new-panel
> +          - const: allwinner,sun50i-a64
> +

We're on the right track, but new panel seems a bit too vague. What is
going to happen when they will change the panel again?

pinetab-early-adopter seems more robust there

Maxime

--jypi6ln6e6jthjwh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9dAUAAKCRDj7w1vZxhR
xY3uAPwIOL8SxCSyIM1zUHuDEuyjbgPAbZ6jyJnIgY8dOhO0CwD+NGmV9Kc113Q+
BM1jdGb7U1m6WrQVCweD5rvLGl/nGgs=
=ewmA
-----END PGP SIGNATURE-----

--jypi6ln6e6jthjwh--