Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2595824pxu; Mon, 14 Dec 2020 06:30:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJzuYOMKxbe2OLqMfV1mizueqzMPKYj9+VK1GUcc9NXc3N71+Toq3JDP7XkhHXZ5I1CRSyLB X-Received: by 2002:a05:6402:2074:: with SMTP id bd20mr24554458edb.326.1607956210377; Mon, 14 Dec 2020 06:30:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607956210; cv=none; d=google.com; s=arc-20160816; b=kYbQo/ueFrp1+o3bYqcr8W2/Ad/3iU0ugBb3iB02A6J/Q98fz//wHPL+ceyqRah4b4 9EFzf0DfjBz+qtV4jiT9PS2UZ9Nn8wN2eXw9qvzL7jPxaTGE+RDiNO2G6Ls4cV3XKP8S cDng8nFW/58ZLqVuaN1D5DVfa6qzWMkJCSQTLf8w3NFHuBXUwJ9+mPibnYl7q4NLy4GQ j/Zm2NGrli8e3TGyEQsKNje2+aTram6526k/4WzIkTJtd68nvnqfLTWWKicpzAOvR7fm zKfogi69Y0mtOSpxtvpvpzw9nfAHMPzj+mLdL6KZhK1aeJEk4F/aM0oVZIF+VIsCnjfD dCOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ETJkm2h9mUdQRDtcG4X/2MD3yrQCIlxA3Hfl870jwj4=; b=B1RzXWXtWGXuUIWjyQwsG8vI2NlLTVPIqpgOoIZ4Sgm7NLpFBlva2EW2ZS25NFzGn0 gBx4Fo4grxdECjq0LkaRLwuKCR6imUPpSng1AJPq+okHBhE/jc41KdsB3i7oEpHApC/u Y4eEXhAZD+4aqccCX11FxUzwfkEbBbhUyhaJJVQHEyF/t2VNbc5DdneS9iwMnUsIIG/J ycw+VM2Ia8736WPB/LsnU2DUCNKM18P2Bmph0MxdamzxMCgZsqfX8D8c49GPDQYdOJBc C+RSNi8yBdDEdyc3M4dFyZdnTEC3jnJS9P6EheogIB2X/RiNUkJtUiF8s9aytzaxtUGo TaNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=r25mGmNk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y22si11254420ejc.25.2020.12.14.06.29.45; Mon, 14 Dec 2020 06:30:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=r25mGmNk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437066AbgLNLVK (ORCPT + 99 others); Mon, 14 Dec 2020 06:21:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437219AbgLNLUu (ORCPT ); Mon, 14 Dec 2020 06:20:50 -0500 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1076DC0613CF; Mon, 14 Dec 2020 03:20:10 -0800 (PST) Received: by mail-pj1-x1043.google.com with SMTP id z12so6112108pjn.1; Mon, 14 Dec 2020 03:20:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ETJkm2h9mUdQRDtcG4X/2MD3yrQCIlxA3Hfl870jwj4=; b=r25mGmNkMaVymoukJdYxFlGJGfK3XkU1Ny6frMPmg1Fdb4iaEVZVO5QJxKuLBsNJCd 9XIjrmInI0sKFHvqhJeTasbCPeKoST0dYXVhh4kAwaiDpK3laTHnDD+5gjnjupU8Mzwe JLq3IWBkN+fpgnsUsbkaGyuzOcZhMzCkaWWU0/f/zXhUnxzXpa89XE5mmqtgUXmywH2O 1ElETGTCZHt/SjBNRVeHXfxYwdu5YNvQMXijPywj125EwbqRD7balLvykrWwlfNoQg6j sQyhCi1yW6GLYyDZA2T4UUiKctuaj0MJDVQL9YFMTS/kBY2AQQGLnYxqG9bbWAIj9TUP KShg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ETJkm2h9mUdQRDtcG4X/2MD3yrQCIlxA3Hfl870jwj4=; b=m4EH+dIxDKEWHj/OugtKAY/Z4bfqdtDUHusT6fVYTtMaJZm2TTu6ECsz4csH9x2ff/ B4k/+kw7fxl7KsWwL83QjNsil1ayHDtRZMwfXM4g80y1+z6aVQtcMSiyot1sWQ1fDYBp vkcCcMquiRUtvUu8VjNyBmf+AWKxga+z+8IMtogATNPNiFmiWdPcfmHf9b2rLfeQUDZM h3k5lRT4iK/1athnIv4sqP8GzyXKllvoTO3t1ZoEaO5sIr7aEwkEzu4qEAJsNEGjmdv0 vz3oKYrwyPh619W2BQFYSqZDSUBp7noMR9p0Qxn9oq/ISTfhYLXBi0jidPU+bM2sq4CB Ga0Q== X-Gm-Message-State: AOAM532V3EMtO6zpD+iXij95fSxEli161w13K7lwo6O8W3e0D0Z/A7t+ otxXp8+WkYT5u1jGgDxw9dT6nz6FkrgRRhTKJyo= X-Received: by 2002:a17:90b:a17:: with SMTP id gg23mr25511515pjb.129.1607944809447; Mon, 14 Dec 2020 03:20:09 -0800 (PST) MIME-Version: 1.0 References: <20201211190335.16501-1-rdunlap@infradead.org> <3d5a5c8f-4bb1-6205-ae76-354473d59a18@infradead.org> In-Reply-To: <3d5a5c8f-4bb1-6205-ae76-354473d59a18@infradead.org> From: Andy Shevchenko Date: Mon, 14 Dec 2020 13:19:52 +0200 Message-ID: Subject: Re: [PATCH -next] platform: surface: fix non-PM_SLEEP build warnings To: Randy Dunlap , Arnd Bergmann Cc: Linux Kernel Mailing List , Maximilian Luz , Hans de Goede , Platform Driver Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 14, 2020 at 2:53 AM Randy Dunlap wrote: > On 12/12/20 11:07 AM, Andy Shevchenko wrote: > > On Sat, Dec 12, 2020 at 7:05 PM Randy Dunlap wrote: ... > > Here [1] is the rationale behind annotation vs. ifdeffery. > > > > [1]: https://lore.kernel.org/patchwork/patch/732981/ > > > Thanks for the link. I'll send a v2. > > Could we add that to the Linux BKP (Best Known Practices) > document? Perhaps. The author of that is Arnd, maybe he has something to add. -- With Best Regards, Andy Shevchenko