Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Punit Agrawal <punitagrawal@gmail.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     Wei Huang <whuang2@amd.com>, rjw@rjwysocki.net, wei.huang2@amd.com,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        x86@kernel.org
Subject: Re: [RFC PATCH 2/4] cpufreq: acpi-cpufreq: Add processor to the
 ignore PSD override list
In-Reply-To: <20201214124023.GA25916@zn.tnic> (Borislav Petkov's message of
        "Mon, 14 Dec 2020 13:40:23 +0100")
References: <20201125144847.3920-1-punitagrawal@gmail.com>
        <20201125144847.3920-3-punitagrawal@gmail.com>
        <cadb5d57-5aaf-79bc-e30e-502d5e522689@amd.com>
        <20201207202610.GG20489@zn.tnic>
        <e9b4ae11-1fe3-a660-bb65-d3ba55ffcc56@amd.com>
        <20201207223057.GJ20489@zn.tnic> <87a6unq3xv.fsf@stealth>
        <20201208233216.GH27920@zn.tnic> <871rfvoqy7.fsf@stealth>
        <20201214124023.GA25916@zn.tnic>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
Date:   Mon, 14 Dec 2020 22:27:09 +0900
Message-ID: <87sg88tt5e.fsf@stealth>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Borislav Petkov <bp@alien8.de> writes:

> On Sat, Dec 12, 2020 at 08:36:48AM +0900, Punit Agrawal wrote:
>> To me it suggests, that there are likely more systems from the family
>> that show the characteristic described below.
>
> Until we find a *single* system with a broken BIOS which has those
> objects kaputt and then this heuristic would need an exception.
>
> VS the clear statement from AMD that from zen3 onwards, all BIOS will be
> tested. I hope they boot Linux at least before they ship.

IIUC, this suggests that Linux booting on anything prior to Zen3 is down
to pure luck - I hope that wasn't the case.

>> In all these systems, the override causes this topology information to
>> be ignored - treating each core to be a separate domain. The proposed
>> patch removes the override so that _PSD is taken into account.
>
> You're still not answering my question: what does the coupling of the
> SMT threads bring on those systems? Power savings? Perf improvement?
> Anything palpable or measurable?

At the moment acpi thermals is bust on this and other affected AMD
system I have access to. That'll need fixing before any sensible
measurements can be run.

Tbh, I didn't quite expect the patch to the PSD exclusion list to be so
controversial - especially when a similar change for zen3 had recently
been merged. If you're really not keen on the change, I will carry it
locally for the time being and revisit once the other issues have been
resolved.