Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 14 Dec 2020 15:21:18 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Icenowy Zheng <icenowy@aosc.io>
Cc:     Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio@vger.kernel.org
Subject: Re: [RFC PATCH 05/12] pinctrl: sunxi: add pinctrl driver for
 V831/V833
Message-ID: <20201214142118.bxdzu7z7cdomhgy7@gilmour>
References: <20201212040157.3639864-1-icenowy@aosc.io>
 <20201212040430.3640418-2-icenowy@aosc.io>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="rchau4rbhiwycv2k"
Content-Disposition: inline
In-Reply-To: <20201212040430.3640418-2-icenowy@aosc.io>
Precedence: bulk


--rchau4rbhiwycv2k
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 12, 2020 at 12:04:23PM +0800, Icenowy Zheng wrote:
> V831/V833 are new chips from Allwinner. They're the same die with
> different package.
>=20
> Add a pinctrl driver for them.
>=20
> The difference between V831/V833 pinctrl is implemented based on the
> user manual.
>=20
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  drivers/pinctrl/sunxi/Kconfig              |   5 +
>  drivers/pinctrl/sunxi/Makefile             |   1 +
>  drivers/pinctrl/sunxi/pinctrl-sun8i-v83x.c | 743 +++++++++++++++++++++
>  drivers/pinctrl/sunxi/pinctrl-sunxi.h      |   2 +
>  4 files changed, 751 insertions(+)
>  create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun8i-v83x.c
>=20
> diff --git a/drivers/pinctrl/sunxi/Kconfig b/drivers/pinctrl/sunxi/Kconfig
> index 593293584ecc..fc13335a3eda 100644
> --- a/drivers/pinctrl/sunxi/Kconfig
> +++ b/drivers/pinctrl/sunxi/Kconfig
> @@ -73,6 +73,11 @@ config PINCTRL_SUN8I_V3S
>  	default MACH_SUN8I
>  	select PINCTRL_SUNXI
> =20
> +config PINCTRL_SUN8I_V83X
> +	bool "Support for the Allwinner V831/V833 PIO"
> +	default MACH_SUN8I
> +	select PINCTRL_SUNXI
> +

We're not using the wildcard much, and I'd rather be consistent with the
name / Kconfig option scheme used for the clock driver (and the rest of
the SoCs in a similar situation)

Maxime

--rchau4rbhiwycv2k
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9d03gAKCRDj7w1vZxhR
xbPvAQCq17o8gHL1yUSGIQCGeqX51CHQBMYjDd0RI8x/CV4EuAEA/opdKZPWikSe
DNBii3EVWa8xj+3RRyjhq8gfj/VMwg4=
=HJdK
-----END PGP SIGNATURE-----

--rchau4rbhiwycv2k--