Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 14 Dec 2020 15:38:07 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Icenowy Zheng <icenowy@aosc.io>
Cc:     Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
        linux-mmc@vger.kernel.org
Subject: Re: [RFC PATCH 08/12] dt-bindings: mmc: sunxi: add compatible
 strings for V831 MMC
Message-ID: <20201214143807.3wsot6yk4z6s32u5@gilmour>
References: <20201212040157.3639864-1-icenowy@aosc.io>
 <20201212050346.3644673-1-icenowy@aosc.io>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="a6eeaa2leewxdmgu"
Content-Disposition: inline
In-Reply-To: <20201212050346.3644673-1-icenowy@aosc.io>
Precedence: bulk


--a6eeaa2leewxdmgu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 12, 2020 at 01:03:42PM +0800, Icenowy Zheng wrote:
> V831 has MMC controllers similar to the ones on H6.
>=20
> Add a compatible string for them.
>=20
> The eMMC controller compatible is not added, because the eMMC controller
> is not available on V831, only V833.
>=20
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-mmc@vger.kernel.org
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>

There's pretty much the same comment than on the H616, it would be great
to not have any mode flags being set by the driver to avoid the mess we
have on the older SoCs right now.

Maxime

--a6eeaa2leewxdmgu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9d4zwAKCRDj7w1vZxhR
xeatAQDlfmtMP5DKMl4QYDtMXUTYVkUEr47s/NVuvZOKmuYQ+AD7B1b1CtM9BG2Q
TiZsaeXjCGmbFXswP8LlUIdf8b3UhgE=
=csW8
-----END PGP SIGNATURE-----

--a6eeaa2leewxdmgu--