Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Tp3EbnfyUaI5AOqm+hEfjfybllrEAt6TrRmP1z6XLNwCDSUpEtWwYIMDOhiDpCAan9hzMw+EQw
 hGsox1ka+y+Eed6lFZoeumYTQwdBcGpvCxkmFBa9RA9IOQYF/ncvMwrGqyGwMB+GAf19fDlxPD
 P75SMhQ5isIzwXY+giHBVO07bd/Rthm/oRMYL61gckAeJSxeaGLcNR2bNfspIlvvdfDMym+kcg
 ymxIYm2y6fhKR2ueNVPc5tq8cAFA+lyept7RCX4cyb+wDDzdJCldJXQBTcNO1+qY1JBnu8uv5P
 eT0=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <huobean@gmail.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        "joe@perches.com" <joe@perches.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 0/6] Several changes for the UPIU trace
Thread-Topic: [PATCH v3 0/6] Several changes for the UPIU trace
Thread-Index: AQHW0laTiGmP3/RbQ06ZncSGQQv6/an3JGug
Date:   Mon, 14 Dec 2020 22:13:39 +0000
Message-ID: <DM6PR04MB657559FA01C44B411BBDBDBCFCC70@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20201214202014.13835-1-huobean@gmail.com>
In-Reply-To: <20201214202014.13835-1-huobean@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d5c03e7-3185-4a17-61d2-08d8a07d8296
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2020 22:13:39.4443
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: B6gqvgJ7bxDMf8eA5tUGslxOY8IkorJoIKB405pbABvBYAjMnhC677V7MUY8WfyCiXQwZ6dH3Gym7b5qw8EJhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB4426
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Bean Hi,
I support this series.
I think it is a good idea to print the response on complete,
But you need to change the prefix strings, otherwise you are breaking the c=
urrent parsers.

Say that you have a trace log, generated sometime during 2020 using the cur=
rent upiu trace.
It would look something like:
"send" <request upiu>
"complete" <request upiu>

And another log generated sometime during 2021 after your change is merged:
"send" <request upiu>
"complete" < ****response upiu ****>

The current parser won't be able to differentiate between those logs.
Just change the prefix strings to be "send_req" and "complete_rsp", or some=
thing,
so the parsing tools that support the new format will be able to differenti=
ate it from the old one.
 =20
Also, once the parser can differentiate the new format from the old,
whatever follows its fine: cdb / osf / tsf or whatever makes sense to you.

Thanks,
Avri
=20

> -----Original Message-----
> From: Bean Huo <huobean@gmail.com>
> Sent: Monday, December 14, 2020 10:20 PM
> To: alim.akhtar@samsung.com; Avri Altman <Avri.Altman@wdc.com>;
> asutoshd@codeaurora.org; jejb@linux.ibm.com;
> martin.petersen@oracle.com; stanley.chu@mediatek.com;
> beanhuo@micron.com; bvanassche@acm.org; tomas.winkler@intel.com;
> cang@codeaurora.org; rostedt@goodmis.org; joe@perches.com
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH v3 0/6] Several changes for the UPIU trace
>=20
> CAUTION: This email originated from outside of Western Digital. Do not cl=
ick
> on links or open attachments unless you recognize the sender and know tha=
t
> the content is safe.
>=20
>=20
> From: Bean Huo <beanhuo@micron.com>
>=20
> Changelog:
>=20
> V2--V3:
>   1. Fix a typo in patch 1/6 (Reported-by: Joe Perches <joe@perches.com>)
>=20
> V1--V2:
>   1. Convert __get_str(str) to __print_symbolic()
>   2. Add new patches 1/6, 2/6,3/6
>   3. Use __print_symbolic() in patch 6/6
>=20
> Bean Huo (6):
>   scsi: ufs: Remove stringize operator '#' restriction
>   scsi: ufs: Use __print_symbolic() for UFS trace string print
>   scsi: ufs: Don't call trace_ufshcd_upiu() in case trace poit is
>     disabled
>   scsi: ufs: Distinguish between query REQ and query RSP in query trace
>   scsi: ufs: Distinguish between TM request UPIU and response UPIU in TM
>     UPIU trace
>   scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM
>=20
>  drivers/scsi/ufs/ufs.h     |  17 ++++++
>  drivers/scsi/ufs/ufshcd.c  |  72 ++++++++++++++++---------
>  include/trace/events/ufs.h | 108 +++++++++++++++++++++++--------------
>  3 files changed, 131 insertions(+), 66 deletions(-)
>=20
> --
> 2.17.1